From: Francois Romieu <romieu@fr.zoreil.com>
To: James Morris <jmorris@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>,
Stephen Smalley <sds@epoch.ncsc.mil>,
neilb@cse.unsw.edu.au, viro@parcelfarce.linux.theplanet.co.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][LIBFS] Move transaction file ops into libfs + cleanup (update)
Date: Sat, 14 Aug 2004 20:20:27 +0200 [thread overview]
Message-ID: <20040814182027.GA23293@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <Xine.LNX.4.44.0408141231300.27007-100000@dhcp83-76.boston.redhat.com>
James Morris <jmorris@redhat.com> :
[...]
> diff -urN -X dontdiff linux-2.6.8.1.o/include/linux/fs.h linux-2.6.8.1.w/include/linux/fs.h
> --- linux-2.6.8.1.o/include/linux/fs.h 2004-08-14 10:25:44.000000000 -0400
> +++ linux-2.6.8.1.w/include/linux/fs.h 2004-08-14 12:57:56.175796496 -0400
> @@ -1550,6 +1550,32 @@
[...]
> +static inline void simple_transaction_set(struct file *file, size_t n)
> +{
> + struct simple_transaction_argresp *ar = file->private_data;
> +
> + BUG_ON(n > SIMPLE_TRANSACTION_LIMIT);
> + mb();
> + ar->size = n;
> +}
Could you add the justification for the 'mb' (or the expected effect on the
api) as a comment ?
--
Ueimor
next prev parent reply other threads:[~2004-08-14 18:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-13 16:05 [PATCH][LIBFS] Move transaction file ops into libfs James Morris
2004-08-14 16:44 ` [PATCH][LIBFS] Move transaction file ops into libfs + cleanup (update) James Morris
2004-08-14 18:20 ` Francois Romieu [this message]
2004-08-14 19:32 ` James Morris
2004-08-15 22:32 ` Andrew Morton
2004-08-15 23:44 ` James Morris
2004-08-16 0:11 ` James Morris
2004-08-14 19:55 ` Chris Wright
2004-08-14 20:23 ` viro
2004-08-14 20:41 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040814182027.GA23293@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=akpm@osdl.org \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=sds@epoch.ncsc.mil \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®