From: Andrew Morton <akpm@osdl.org>
To: James Morris <jmorris@redhat.com>
Cc: romieu@fr.zoreil.com, sds@epoch.ncsc.mil, neilb@cse.unsw.edu.au,
viro@parcelfarce.linux.theplanet.co.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][LIBFS] Move transaction file ops into libfs + cleanup (update)
Date: Sun, 15 Aug 2004 15:32:11 -0700 [thread overview]
Message-ID: <20040815153211.1367066f.akpm@osdl.org> (raw)
In-Reply-To: <Xine.LNX.4.44.0408141524530.27390-100000@dhcp83-76.boston.redhat.com>
James Morris <jmorris@redhat.com> wrote:
>
> On Sat, 14 Aug 2004, Francois Romieu wrote:
>
> > > +static inline void simple_transaction_set(struct file *file, size_t n)
> > > +{
> > > + struct simple_transaction_argresp *ar = file->private_data;
> > > +
> > > + BUG_ON(n > SIMPLE_TRANSACTION_LIMIT);
> > > + mb();
> > > + ar->size = n;
> > > +}
> >
> > Could you add the justification for the 'mb' (or the expected effect on the
> > api) as a comment ?
>
> This ensures that ar->size will really remain zero until ar->data is ready
> for reading.
I updated the patch to include this important detail in a comment.
Shouldn't it be an smb_mb()?
next prev parent reply other threads:[~2004-08-15 22:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-13 16:05 [PATCH][LIBFS] Move transaction file ops into libfs James Morris
2004-08-14 16:44 ` [PATCH][LIBFS] Move transaction file ops into libfs + cleanup (update) James Morris
2004-08-14 18:20 ` Francois Romieu
2004-08-14 19:32 ` James Morris
2004-08-15 22:32 ` Andrew Morton [this message]
2004-08-15 23:44 ` James Morris
2004-08-16 0:11 ` James Morris
2004-08-14 19:55 ` Chris Wright
2004-08-14 20:23 ` viro
2004-08-14 20:41 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040815153211.1367066f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=romieu@fr.zoreil.com \
--cc=sds@epoch.ncsc.mil \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®