From: Sam Ravnborg <sam@ravnborg.org>
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: [BK PATCH] kbuild: fix cc-version
Date: Tue, 24 Aug 2004 22:44:44 +0200 [thread overview]
Message-ID: <20040824204444.GA26136@mars.ravnborg.org> (raw)
When consolidating gcc version handling a bug were introduced.
It made make spit out
/bin/sh: line 1: [: too many arguments
when building the kernel.
As a side-effect all gcc version checks were failing.
Patch below.
Linus - please pull from
bk://linux-sam.bkbits.net/kbuild
[Only cset pushed since last update].
Sam
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/08/24 22:36:35+02:00 sam@mars.ravnborg.org
# kbuild: fix cc-version
#
# cc-version needs to use $(shell to get the gcc version.
# Before if gave the following error when building the kernel:
#
# /bin/sh: line 1: [: too many arguments
#
# And all checks for gcc version were broken.
#
# Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
#
# Makefile
# 2004/08/24 22:34:30+02:00 sam@mars.ravnborg.org +2 -2
# fix cc-version
#
diff -Nru a/Makefile b/Makefile
--- a/Makefile 2004-08-24 22:37:19 +02:00
+++ b/Makefile 2004-08-24 22:37:19 +02:00
@@ -279,8 +279,8 @@
# cc-version
# Usage gcc-ver := $(call cc-version $(CC))
-cc-version = $(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh \
- $(if $(1), $(1), $(CC))
+cc-version = $(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh \
+ $(if $(1), $(1), $(CC)))
# Look for make include files relative to root of kernel src
reply other threads:[~2004-08-24 20:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040824204444.GA26136@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®