mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [BK PATCH] kbuild: fix cc-version
@ 2004-08-24 20:44 Sam Ravnborg
  0 siblings, 0 replies; only message in thread
From: Sam Ravnborg @ 2004-08-24 20:44 UTC (permalink / raw)
  To: Linus Torvalds, Andrew Morton, linux-kernel

When consolidating gcc version handling a bug were introduced.
It made make spit out

/bin/sh: line 1: [: too many arguments

when building the kernel.
As a side-effect all gcc version checks were failing.

Patch below.

Linus - please pull from
bk://linux-sam.bkbits.net/kbuild

[Only cset pushed since last update].

	Sam

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/08/24 22:36:35+02:00 sam@mars.ravnborg.org 
#   kbuild: fix cc-version
#   
#   cc-version needs to use $(shell to get the gcc version.
#   Before if gave the following error when building the kernel:
#   
#   /bin/sh: line 1: [: too many arguments
#   
#   And all checks for gcc version were broken.
#   
#   Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
# 
# Makefile
#   2004/08/24 22:34:30+02:00 sam@mars.ravnborg.org +2 -2
#   fix cc-version
# 
diff -Nru a/Makefile b/Makefile
--- a/Makefile	2004-08-24 22:37:19 +02:00
+++ b/Makefile	2004-08-24 22:37:19 +02:00
@@ -279,8 +279,8 @@
 
 # cc-version
 # Usage gcc-ver := $(call cc-version $(CC))
-cc-version = $(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh \
-              $(if $(1), $(1), $(CC))
+cc-version = $(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh \
+              $(if $(1), $(1), $(CC)))
 
 
 # Look for make include files relative to root of kernel src

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-08-24 20:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-08-24 20:44 [BK PATCH] kbuild: fix cc-version Sam Ravnborg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®