* swsusp error: do not oops after allocation failure
@ 2004-08-28 21:23 Pavel Machek
0 siblings, 0 replies; only message in thread
From: Pavel Machek @ 2004-08-28 21:23 UTC (permalink / raw)
To: kernel list, Andrew Morton, Patrick Mochel
Hi!
This checks error return from swsusp_alloc, preventing oops when
memory can not be allocated. Please apply,
Pavel
--- clean-mm.middle/kernel/power/swsusp.c 2004-08-20 14:11:31.000000000 +0200
+++ linux-mm/kernel/power/swsusp.c 2004-08-28 23:18:52.000000000 +0200
@@ -677,9 +677,9 @@
calc_order();
pagedir_save = (suspend_pagedir_t *)__get_free_pages(GFP_ATOMIC | __GFP_COLD,
pagedir_order);
- if(!pagedir_save)
+ if (!pagedir_save)
return -ENOMEM;
- memset(pagedir_save,0,(1 << pagedir_order) * PAGE_SIZE);
+ memset(pagedir_save, 0, (1 << pagedir_order) * PAGE_SIZE);
pagedir_nosave = pagedir_save;
return 0;
}
@@ -784,6 +784,7 @@
int suspend_prepare_image(void)
{
unsigned int nr_needed_pages = 0;
+ int error;
pr_debug("swsusp: critical section: \n");
if (save_highmem()) {
@@ -796,7 +797,9 @@
printk("swsusp: Need to copy %u pages\n",nr_copy_pages);
nr_needed_pages = nr_copy_pages + PAGES_FOR_IO;
- swsusp_alloc();
+ error = swsusp_alloc();
+ if (error)
+ return error;
/* During allocating of suspend pagedir, new cold pages may appear.
* Kill them.
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-08-28 21:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-08-28 21:23 swsusp error: do not oops after allocation failure Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®