From: Roland McGrath <roland@redhat.com>
To: Daniel Jacobowitz <dan@debian.org>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cleanup ptrace stops and remove notify_parent
Date: Mon, 30 Aug 2004 21:55:30 -0700 [thread overview]
Message-ID: <200408310455.i7V4tUPk001916@magilla.sf.frob.com> (raw)
In-Reply-To: Daniel Jacobowitz's message of Tuesday, 31 August 2004 00:22:06 -0400 <20040831042206.GA10577@nevyn.them.org>
> Unless it's been changed since I last pulled, you should also fix up
> has_stopped_jobs. I think it's broken by the introduction of
> TASK_TRACED.
Actually, I don't think it was broken at all. It has an old kludge to
avoid considering trace-stopped threads as stopped for purposes of deciding
to generate signals for an orphaned process group. I think that the useful
thing is for it not to consider any TASK_TRACED thread as stopped here either.
That's what it will already do, and the old kludge can go now:
--- linux-2.6-ptracefix/kernel/exit.c.~1~
+++ linux-2.6-ptracefix/kernel/exit.c
@@ -199,17 +199,6 @@ static inline int has_stopped_jobs(int p
for_each_task_pid(pgrp, PIDTYPE_PGID, p, l, pid) {
if (p->state != TASK_STOPPED)
continue;
-
- /* If p is stopped by a debugger on a signal that won't
- stop it, then don't count p as stopped. This isn't
- perfect but it's a good approximation. */
- if (unlikely (p->ptrace)
- && p->exit_code != SIGSTOP
- && p->exit_code != SIGTSTP
- && p->exit_code != SIGTTOU
- && p->exit_code != SIGTTIN)
- continue;
-
retval = 1;
break;
}
Thanks,
Roland
next prev parent reply other threads:[~2004-08-31 4:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-31 3:25 Roland McGrath
2004-08-31 3:43 ` Andrew Morton
2004-08-31 4:11 ` Roland McGrath
2004-08-31 4:26 ` Andrew Morton
2004-08-31 5:43 ` Roland McGrath
2004-08-31 4:27 ` Linus Torvalds
2004-08-31 4:50 ` Roland McGrath
2004-08-31 13:19 ` OGAWA Hirofumi
2004-08-31 13:56 ` Daniel Jacobowitz
2004-09-01 0:11 ` Roland McGrath
2004-09-01 4:25 ` OGAWA Hirofumi
2004-08-31 9:29 ` Christoph Hellwig
2004-08-31 9:43 ` Anton Blanchard
2004-09-01 0:00 ` Roland McGrath
2004-08-31 3:59 ` Roland McGrath
2004-08-31 4:22 ` Daniel Jacobowitz
2004-08-31 4:55 ` Roland McGrath [this message]
2004-08-31 4:59 ` Daniel Jacobowitz
[not found] <2z7vs-2F1-13@gated-at.bofh.it>
2004-08-31 10:00 ` Andi Kleen
2004-09-01 0:27 ` Roland McGrath
2004-09-01 1:56 ` Roland McGrath
2004-09-04 13:38 ` Andi Kleen
2004-08-31 15:59 Albert Cahalan
2004-08-31 23:54 ` Roland McGrath
2004-09-01 0:27 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200408310455.i7V4tUPk001916@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=akpm@osdl.org \
--cc=dan@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®