mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Anton Blanchard <anton@samba.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	Andrew Morton <akpm@osdl.org>,
	torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cleanup ptrace stops and remove notify_parent
Date: Tue, 31 Aug 2004 17:00:29 -0700	[thread overview]
Message-ID: <200409010000.i8100TvP001852@magilla.sf.frob.com> (raw)
In-Reply-To: Anton Blanchard's message of  Tuesday, 31 August 2004 19:43:48 +1000 <20040831094348.GH26072@krispykreme>

> 
> > Just about every architecture hasa line
> > 
> > +	ptrace_notify(SIGTRAP | ((current->ptrace & PT_TRACESYSGOOD)  ? 0x80 : 0));
> > 
> > you probably want a one-liner inline wrapper with a descriptive name
> > around this
> 
> Yep, and it looks like only some architectures got this recent change:
> 
>         ptrace_notify(SIGTRAP | ((current->ptrace & PT_TRACESYSGOOD) &&
>                                  !test_thread_flag(TIF_SINGLESTEP) ?  0x80 : 0));
> 
> Is there a reason this shouldnt be propogated to all architectures?

It ought to produce the the same result on all, certainly.  TIF_SINGLESTEP
is an implementation detail specific to i386 and x86_64.  The new test here
makes sure that PTRACE_SINGLESTEP never produces an 0x80|SIGTRAP
notification, only PTRACE_SYSCALL, to be consistent with previous behavior.
This i386/x86_64 code path can now be entered for the single-step case, due
to changes that just went in to make single-stepping the system call
instruction work nicely.  If other machines require similar fixes and the
implementation overloads their syscall_trace functions in the same way,
then they will have a change similar to this one to make.


Thanks,
Roland

  reply	other threads:[~2004-09-01  0:05 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-31  3:25 Roland McGrath
2004-08-31  3:43 ` Andrew Morton
2004-08-31  4:11   ` Roland McGrath
2004-08-31  4:26     ` Andrew Morton
2004-08-31  5:43       ` Roland McGrath
2004-08-31  4:27     ` Linus Torvalds
2004-08-31  4:50       ` Roland McGrath
2004-08-31 13:19       ` OGAWA Hirofumi
2004-08-31 13:56         ` Daniel Jacobowitz
2004-09-01  0:11         ` Roland McGrath
2004-09-01  4:25           ` OGAWA Hirofumi
2004-08-31  9:29     ` Christoph Hellwig
2004-08-31  9:43       ` Anton Blanchard
2004-09-01  0:00         ` Roland McGrath [this message]
2004-08-31  3:59 ` Roland McGrath
2004-08-31  4:22 ` Daniel Jacobowitz
2004-08-31  4:55   ` Roland McGrath
2004-08-31  4:59     ` Daniel Jacobowitz
     [not found] <2z7vs-2F1-13@gated-at.bofh.it>
2004-08-31 10:00 ` Andi Kleen
2004-09-01  0:27   ` Roland McGrath
2004-09-01  1:56     ` Roland McGrath
2004-09-04 13:38       ` Andi Kleen
2004-08-31 15:59 Albert Cahalan
2004-08-31 23:54 ` Roland McGrath
2004-09-01  0:27   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200409010000.i8100TvP001852@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=akpm@osdl.org \
    --cc=anton@samba.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®