From: Adrian Bunk <bunk@fs.tum.de>
To: Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@muc.de>
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] kill __always_inline
Date: Wed, 1 Sep 2004 00:13:48 +0200 [thread overview]
Message-ID: <20040831221348.GW3466@fs.tum.de> (raw)
An issue that we already discussed at 2.6.8-rc2-mm2 times:
2.6.9-rc1 includes __always_inline which was formerly in -mm.
__always_inline doesn't make any sense:
__always_inline is _exactly_ the same as __inline__, __inline and inline .
The patch below removes __always_inline again:
Signed-off-by: Adrian Bunk <bunk@fs.tum.de>
--- linux-2.6.9-rc1-mm2-full/include/linux/compiler.h.old 2004-08-31 23:30:51.000000000 +0200
+++ linux-2.6.9-rc1-mm2-full/include/linux/compiler.h 2004-08-31 23:31:09.000000000 +0200
@@ -124,8 +124,4 @@
#define noinline
#endif
-#ifndef __always_inline
-#define __always_inline inline
-#endif
-
#endif /* __LINUX_COMPILER_H */
--- linux-2.6.9-rc1-mm2-full/include/asm-i386/fixmap.h.old 2004-08-31 23:31:35.000000000 +0200
+++ linux-2.6.9-rc1-mm2-full/include/asm-i386/fixmap.h 2004-08-31 23:31:47.000000000 +0200
@@ -129,7 +129,7 @@
* directly without tranlation, we catch the bug with a NULL-deference
* kernel oops. Illegal ranges of incoming indices are caught too.
*/
-static __always_inline unsigned long fix_to_virt(const unsigned int idx)
+static inline unsigned long fix_to_virt(const unsigned int idx)
{
/*
* this branch gets completely eliminated after inlining,
next reply other threads:[~2004-08-31 22:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-31 22:13 Adrian Bunk [this message]
2004-08-31 22:36 ` Andrew Morton
2004-08-31 22:52 ` Adrian Bunk
2004-08-31 23:01 ` Andrew Morton
2004-08-31 23:12 ` Nigel Cunningham
2004-08-31 23:39 ` Andrew Morton
2004-08-31 23:41 ` Nigel Cunningham
2004-09-02 19:46 ` Adrian Bunk
2004-09-02 23:12 ` Tim Bird
2004-09-02 23:25 ` Andrew Morton
[not found] <2zpiO-72f-37@gated-at.bofh.it>
[not found] ` <2zpC1-7fh-13@gated-at.bofh.it>
[not found] ` <2zpVj-7yW-3@gated-at.bofh.it>
[not found] ` <2zqeK-7JB-3@gated-at.bofh.it>
2004-08-31 23:43 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040831221348.GW3466@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome