mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Tim Bird <tim.bird@am.sony.com>
Cc: bunk@fs.tum.de, ncunningham@linuxmail.org, ak@muc.de,
	linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch]  kill __always_inline
Date: Thu, 2 Sep 2004 16:25:45 -0700	[thread overview]
Message-ID: <20040902162545.6b7ae079.akpm@osdl.org> (raw)
In-Reply-To: <4137A8E4.9090803@am.sony.com>

Tim Bird <tim.bird@am.sony.com> wrote:
>
> Finally, I think it's bad form to change the meaning of a compiler
> keyword.  It misleading for 'inline' to mean something different
> in the kernel than it does everywhere else.  It means a developer
> can't use standard gcc documentation to understand kernel code, without
> inside knowledge.  This can be painful for casual or new kernel
> developers.

yes, it's horrid.  But until and unless gcc gets fixed, what choice do we
have?  Without this hack, kernel text size increases significantly.

We don't want to have to patch the kernel source in a zillion places for
what is hopefully a temporary problem.  I'd much rather add `--dwim-dammit'
to the gcc command line.

> +#include <linux/compiler.h>	/* for inline weirdness */
>   #include <asm/param.h>

Mozilla white-space-stuffed your patch.  You'll have to use attachments.


  reply	other threads:[~2004-09-02 23:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-31 22:13 Adrian Bunk
2004-08-31 22:36 ` Andrew Morton
2004-08-31 22:52   ` Adrian Bunk
2004-08-31 23:01     ` Andrew Morton
2004-08-31 23:12     ` Nigel Cunningham
2004-08-31 23:39       ` Andrew Morton
2004-08-31 23:41         ` Nigel Cunningham
2004-09-02 19:46         ` Adrian Bunk
2004-09-02 23:12           ` Tim Bird
2004-09-02 23:25             ` Andrew Morton [this message]
     [not found] <2zpiO-72f-37@gated-at.bofh.it>
     [not found] ` <2zpC1-7fh-13@gated-at.bofh.it>
     [not found]   ` <2zpVj-7yW-3@gated-at.bofh.it>
     [not found]     ` <2zqeK-7JB-3@gated-at.bofh.it>
2004-08-31 23:43       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040902162545.6b7ae079.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=ak@muc.de \
    --cc=bunk@fs.tum.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncunningham@linuxmail.org \
    --cc=tim.bird@am.sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome