mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Wienand <ianw@gelato.unsw.edu.au>
To: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: kbuild: Support LOCALVERSION
Date: Wed, 1 Sep 2004 11:08:40 +1000	[thread overview]
Message-ID: <20040901010840.GL2897@cse.unsw.EDU.AU> (raw)
In-Reply-To: <20040831192642.GA15855@mars.ravnborg.org>

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

On Tue, Aug 31, 2004 at 09:26:43PM +0200, Sam Ravnborg wrote:
> The following patch combines the request from several people.
> If you place a file named localversion* in the root of your
> soruce tree or the root of your output tree the text included in this
> file will be appended to KERNELRELEASE.

With this patch *without* a localversion file I get

ianw@baci:/tmp/kbuild-test$ make
cat: /tmp/kbuild-test/localversion*: No such file or directory
make: *** No rule to make target `/tmp/kbuild-test/localversion*', needed by `include/linux/version.h'.  Stop.

However, with the right files there it works as you describe.

The interaction with LOCALVERSION from the command line (i.e. make
LOCALVERSION=aversion) is still a bit funny too, since it won't cause
version.h to be rebuilt.  Is it going to just be a case of "you can't
specify LOCALVERSION" from the command line?

My original patch also had a Kconfig option which would be inserted; I
figured this might be good because if you're creating a bunch of
different configs you are probably in [menu|x]config to change the
options, so it might be convenient to just set it via a string in
there.  Would anyone else like to see that?

-i

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2004-09-01  1:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-31 19:26 Sam Ravnborg
2004-09-01  1:08 ` Ian Wienand [this message]
2004-09-01  1:24   ` Ian Wienand
2004-09-01  5:11     ` Sam Ravnborg
2004-09-01 11:44 ` Geert Uytterhoeven
2004-09-01 13:14   ` Sam Ravnborg
2004-09-01 13:43 ` Jan-Benedict Glaw
2004-09-01 14:56   ` Sam Ravnborg
2004-09-02 10:42     ` [PATCH] " Ian Wienand
2004-09-05 19:43       ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040901010840.GL2897@cse.unsw.EDU.AU \
    --to=ianw@gelato.unsw.edu.au \
    --cc=akpm@osdl.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®