From: Sam Ravnborg <sam@ravnborg.org>
To: Ian Wienand <ianw@gelato.unsw.edu.au>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: kbuild: Support LOCALVERSION
Date: Wed, 1 Sep 2004 07:11:27 +0200 [thread overview]
Message-ID: <20040901051127.GA7198@mars.ravnborg.org> (raw)
In-Reply-To: <20040901012422.GM2897@cse.unsw.EDU.AU>
On Wed, Sep 01, 2004 at 11:24:22AM +1000, Ian Wienand wrote:
> Sorry to reply to myself, but I forgot to include a suggested patch
> (attached).
>
Thanks for the fix.
> @@ -763,7 +770,7 @@
> )
> endef
>
> -include/linux/version.h: Makefile
> +include/linux/version.h: $(srctree)/Makefile $(localversion-files)
> $(call filechk,version.h)
>
We could just make this:
include/linux/version.h: FORCE
$(call filechk,version.h)
Then version.h would be updated also if LOCALVERSION is specified on
the command line.
Only issue is that it will always be checked - but the same goes for
a few other files.
Sam
next prev parent reply other threads:[~2004-09-01 5:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-31 19:26 Sam Ravnborg
2004-09-01 1:08 ` Ian Wienand
2004-09-01 1:24 ` Ian Wienand
2004-09-01 5:11 ` Sam Ravnborg [this message]
2004-09-01 11:44 ` Geert Uytterhoeven
2004-09-01 13:14 ` Sam Ravnborg
2004-09-01 13:43 ` Jan-Benedict Glaw
2004-09-01 14:56 ` Sam Ravnborg
2004-09-02 10:42 ` [PATCH] " Ian Wienand
2004-09-05 19:43 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040901051127.GA7198@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=ianw@gelato.unsw.edu.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®