EHCI errors in 2.6.8 (could be a patch mistake)

EHCI errors in 2.6.8 (could be a patch mistake)

[Gaetano Sferra]

Hello to all,
please, read carefully:

I've patched my fully working 2.6.7 kernel to the 2.6.8 and I got these errors 
at boot time (no errors during patch and compilation using the same config of 
the 2.6.7 kernel):

ehci_hcd 0000:00:1d.7: BIOS handoff failed (104, 1010001)
ehci_hcd 0000:00:1d.7: can't reset
ehci_hcd 0000:00:1d.7: init 0000:00:1d.7 fail, -95
ehci_hcd: probe of 0000:00:1d.7 failed with error -95

In this condition the hotplugging of USB devices doesn't work at all!
The host controller is an Intel Corp. 82801DB (ICH4) USB2 EHCI and it fully 
work with the 2.6.7. Looking into the patched and original code of the 
ehci-hcd driver I've noticed that some changes has been maded but the only 
one that can influence the BIOS handoff is the following:

kernel 2.6.7 - line 296: cap &= 1 << 24;
kernel 2.6.8 - line 296: cap |= 1 << 24;

This may be a mistake, I don't know, but I've restored that line with the &=
operator and all works again! If this was a typo mistake in the 2.6.8 patch
check the 2.8.9-rc1 also, in the prepatch there is a work-around that force 
the module to exit with code 0!

-- 
Gaetano Sferra
On Jabber: G[a]e@jabber.org

RE: EHCI errors in 2.6.8 (could be a patch mistake)

[Aleksey Gorelov]

>I've patched my fully working 2.6.7 kernel to the 2.6.8 and I 
>got these errors 
>at boot time (no errors during patch and compilation using the 
>same config of 
>the 2.6.7 kernel):
>
>ehci_hcd 0000:00:1d.7: BIOS handoff failed (104, 1010001)
>ehci_hcd 0000:00:1d.7: can't reset
>ehci_hcd 0000:00:1d.7: init 0000:00:1d.7 fail, -95
>ehci_hcd: probe of 0000:00:1d.7 failed with error -95
>
>In this condition the hotplugging of USB devices doesn't work at all!
>The host controller is an Intel Corp. 82801DB (ICH4) USB2 EHCI 
>and it fully 
>work with the 2.6.7. Looking into the patched and original code of the 
>ehci-hcd driver I've noticed that some changes has been maded 
>but the only 
>one that can influence the BIOS handoff is the following:
>
>kernel 2.6.7 - line 296: cap &= 1 << 24;
>kernel 2.6.8 - line 296: cap |= 1 << 24;
                          ^^^^^^^^^^^^^^
This is correct in accordance with EHCI spec.
Could you please try the following patch and see how it goes ?
http://www.mail-archive.com/linux-usb-devel@lists.sourceforge.net/msg270
89.html
Make sure you specify 'usb-handoff' as a kernel parameter.

Pete,
  BTW is this one a 'no go' or just got lost ?

Aleks.