From: Andrew Morton <akpm@osdl.org>
To: janitor@sternwelten.at
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch 11/14] radio/radio-zoltrix: replace sleep_delay() with schedule()
Date: Thu, 2 Sep 2004 15:36:30 -0700 [thread overview]
Message-ID: <20040902153630.60ce9e72.akpm@osdl.org> (raw)
In-Reply-To: <E1C2eLH-0002rZ-CX@sputnik>
janitor@sternwelten.at wrote:
>
> diff -puN drivers/media/radio/radio-zoltrix.c~msleep-drivers_media_radio-zoltrix drivers/media/radio/radio-zoltrix.c
> --- linux-2.6.9-rc1-bk7/drivers/media/radio/radio-zoltrix.c~msleep-drivers_media_radio-zoltrix 2004-09-01 19:35:14.000000000 +0200
> +++ linux-2.6.9-rc1-bk7-max/drivers/media/radio/radio-zoltrix.c 2004-09-01 19:35:14.000000000 +0200
> @@ -54,12 +54,6 @@ struct zol_device {
>
> /* local things */
>
> -static void sleep_delay(void)
> -{
> - /* Sleep nicely for +/- 10 mS */
> - schedule();
> -}
> -
> static int zol_setvol(struct zol_device *dev, int vol)
> {
> dev->curvol = vol;
> @@ -76,7 +70,7 @@ static int zol_setvol(struct zol_device
> }
>
> outb(dev->curvol-1, io);
> - sleep_delay();
> + schedule();
I'm inclined to leave this one as-is. If this driver really wants
to sleep to 10ms then it should do so, rather than doing that
pointless schedule().
prev parent reply other threads:[~2004-09-02 22:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-01 23:16 janitor
2004-09-02 22:36 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040902153630.60ce9e72.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=janitor@sternwelten.at \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome