From: janitor@sternwelten.at
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, janitor@sternwelten.at
Subject: [patch 11/14] radio/radio-zoltrix: replace sleep_delay() with schedule()
Date: Thu, 02 Sep 2004 01:16:38 +0200 [thread overview]
Message-ID: <E1C2eLH-0002rZ-CX@sputnik> (raw)
I would appreciate any comments from the janitor@sternweltens list.
Thanks,
Nish
Description: Replaced sleep_delay() with schedule() in all locations. Removed definition of sleep_delay().
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
---
linux-2.6.9-rc1-bk7-max/drivers/media/radio/radio-zoltrix.c | 24 ++++--------
1 files changed, 9 insertions(+), 15 deletions(-)
diff -puN drivers/media/radio/radio-zoltrix.c~msleep-drivers_media_radio-zoltrix drivers/media/radio/radio-zoltrix.c
--- linux-2.6.9-rc1-bk7/drivers/media/radio/radio-zoltrix.c~msleep-drivers_media_radio-zoltrix 2004-09-01 19:35:14.000000000 +0200
+++ linux-2.6.9-rc1-bk7-max/drivers/media/radio/radio-zoltrix.c 2004-09-01 19:35:14.000000000 +0200
@@ -54,12 +54,6 @@ struct zol_device {
/* local things */
-static void sleep_delay(void)
-{
- /* Sleep nicely for +/- 10 mS */
- schedule();
-}
-
static int zol_setvol(struct zol_device *dev, int vol)
{
dev->curvol = vol;
@@ -76,7 +70,7 @@ static int zol_setvol(struct zol_device
}
outb(dev->curvol-1, io);
- sleep_delay();
+ schedule();
inb(io + 2);
up(&dev->lock);
return 0;
@@ -176,11 +170,11 @@ int zol_getsigstr(struct zol_device *dev
down(&dev->lock);
outb(0x00, io); /* This stuff I found to do nothing */
outb(dev->curvol, io);
- sleep_delay();
- sleep_delay();
+ schedule();
+ schedule();
a = inb(io);
- sleep_delay();
+ schedule();
b = inb(io);
up(&dev->lock);
@@ -202,11 +196,11 @@ int zol_is_stereo (struct zol_device *de
outb(0x00, io);
outb(dev->curvol, io);
- sleep_delay();
- sleep_delay();
+ schedule();
+ schedule();
x1 = inb(io);
- sleep_delay();
+ schedule();
x2 = inb(io);
up(&dev->lock);
@@ -368,8 +362,8 @@ static int __init zoltrix_init(void)
outb(0, io);
outb(0, io);
- sleep_delay();
- sleep_delay();
+ schedule();
+ schedule();
inb(io + 3);
zoltrix_unit.curvol = 0;
_
next reply other threads:[~2004-09-01 23:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-01 23:16 janitor [this message]
2004-09-02 22:36 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1C2eLH-0002rZ-CX@sputnik \
--to=janitor@sternwelten.at \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome