From: Andi Kleen <ak@suse.de>
To: Zwane Mwaikambo <zwane@fsmlabs.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Matt Mackall <mpm@selenic.com>,
William Lee Irwin III <wli@holomorphy.com>,
Andi Kleen <ak@suse.de>
Subject: Re: [PATCH][8/8] Arch agnostic completely out of line locks / x86_64
Date: Sat, 4 Sep 2004 13:16:05 +0200 [thread overview]
Message-ID: <20040904111605.GA12165@wotan.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0409021241291.4481@montezuma.fsmlabs.com>
On Thu, Sep 02, 2004 at 08:03:02PM -0400, Zwane Mwaikambo wrote:
> arch/x86_64/kernel/time.c | 13 +++++++++++++
> arch/x86_64/kernel/vmlinux.lds.S | 1 +
> include/asm-x86_64/ptrace.h | 4 ++++
> 3 files changed, 18 insertions(+)
>
> Andi, i'm not so sure about that return address in profile_pc, i think i
> need to read a bit more.
When frame pointers are enabled the code is correct. But you don't
even need frame pointers, because the spinlock code should not
spill any registers and in such a function the return address
is always *rsp. Same is true on i386 too.
-Andi
next prev parent reply other threads:[~2004-09-04 11:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-03 0:03 Zwane Mwaikambo
2004-09-04 11:16 ` Andi Kleen [this message]
2004-09-04 18:26 ` Zwane Mwaikambo
2004-09-06 7:28 ` Andi Kleen
2004-09-06 16:19 ` Zwane Mwaikambo
2004-09-06 17:50 ` Andi Kleen
2004-09-07 15:33 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040904111605.GA12165@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=torvalds@osdl.org \
--cc=wli@holomorphy.com \
--cc=zwane@fsmlabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®