From: Andi Kleen <ak@suse.de>
To: Zwane Mwaikambo <zwane@linuxpower.ca>
Cc: Andi Kleen <ak@suse.de>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Matt Mackall <mpm@selenic.com>,
William Lee Irwin III <wli@holomorphy.com>
Subject: Re: [PATCH][8/8] Arch agnostic completely out of line locks / x86_64
Date: Mon, 6 Sep 2004 19:50:21 +0200 [thread overview]
Message-ID: <20040906175021.GA27258@wotan.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.53.0409061211440.14053@montezuma.fsmlabs.com>
On Mon, Sep 06, 2004 at 12:19:24PM -0400, Zwane Mwaikambo wrote:
> Hi Andi,
>
> On Mon, 6 Sep 2004, Andi Kleen wrote:
>
> > That is with frame pointers enabled. Indeed with frame pointers
> > on it is not true you still have to special case that.
>
> Yes that was with frame pointers enabled, but the following was compiled
> without frame pointers, i'm still not sure it's safe to use *esp.
No, it's not unfortunately. gcc is aligning the stack
to 8 bytes for floating point. It would if you compiled the file with
-mpreferred-stack-boundary=4. Actually AFAIK this is only useful
for floating point anyways, so it would be a good idea to always
compile the kernel with this option.
On x86-64 it should just work.
-Andi
>
> 00000070 <_spin_lock>:
> 70: 83 ec 04 sub $0x4,%esp
next prev parent reply other threads:[~2004-09-06 17:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-03 0:03 Zwane Mwaikambo
2004-09-04 11:16 ` Andi Kleen
2004-09-04 18:26 ` Zwane Mwaikambo
2004-09-06 7:28 ` Andi Kleen
2004-09-06 16:19 ` Zwane Mwaikambo
2004-09-06 17:50 ` Andi Kleen [this message]
2004-09-07 15:33 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040906175021.GA27258@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=torvalds@osdl.org \
--cc=wli@holomorphy.com \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®