[PATCH] unexport files_lock and put

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

* [PATCH] unexport files_lock and put_filp
@ 2004-09-07 15:06 Christoph Hellwig
  2004-09-07 15:06 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2004-09-07 15:06 UTC (permalink / raw)
  To: akpm; +Cc: linux-kernel

rather lowlevel functions that modules shouldn't mess with and
foruntatly currently don't.


--- 1.36/fs/file_table.c	2004-08-27 08:31:38 +02:00
+++ edited/fs/file_table.c	2004-09-07 14:04:36 +02:00
@@ -24,11 +24,9 @@
 
 EXPORT_SYMBOL(files_stat); /* Needed by unix.o */
 
-/* public *and* exported. Not pretty! */
+/* public. Not pretty! */
 spinlock_t __cacheline_aligned_in_smp files_lock = SPIN_LOCK_UNLOCKED;
 
-EXPORT_SYMBOL(files_lock);
-
 static spinlock_t filp_count_lock = SPIN_LOCK_UNLOCKED;
 
 /* slab constructors and destructors are called from arbitrary
@@ -198,8 +196,6 @@
 		file_free(file);
 	}
 }
-
-EXPORT_SYMBOL(put_filp);
 
 void file_move(struct file *file, struct list_head *list)
 {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] unexport files_lock and put_filp
  2004-09-07 15:06 [PATCH] unexport files_lock and put_filp Christoph Hellwig
@ 2004-09-07 15:06 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2004-09-07 15:06 UTC (permalink / raw)
  To: Christoph Hellwig, akpm, linux-kernel

On Tue, Sep 07, 2004 at 05:06:00PM +0200, Christoph Hellwig wrote:
> rather lowlevel functions that modules shouldn't mess with and

Umm, file_list_lock is of course not a function but a global lock
variable - even worse.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-09-07 15:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-09-07 15:06 [PATCH] unexport files_lock and put_filp Christoph Hellwig
2004-09-07 15:06 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®