* swsusp: another simplifycation
@ 2004-09-10 8:57 Pavel Machek
0 siblings, 0 replies; only message in thread
From: Pavel Machek @ 2004-09-10 8:57 UTC (permalink / raw)
To: kernel list, Andrew Morton, Patrick Mochel
Hi!
verify is not really descriptive name of function. Fortunately its
insides are self-documenting which makes it easy to fix. Please apply,
Pavel
--- clean-mm/kernel/power/swsusp.c 2004-09-07 21:12:33.000000000 +0200
+++ linux-mm/kernel/power/swsusp.c 2004-09-09 08:56:20.000000000 +0200
@@ -1130,17 +1108,6 @@
return error;
}
-
-int __init verify(void)
-{
- int error;
-
- if (!(error = check_sig()))
- error = check_header();
- return error;
-}
-
-
/**
* swsusp_read_data - Read image pages from swap.
*
@@ -1202,13 +1171,14 @@
{
int error = 0;
- if ((error = verify()))
+ if ((error = check_sig()))
+ return error;
+ if ((error = check_header()))
return error;
if ((error = read_pagedir()))
return error;
- if ((error = data_read())) {
- free_pages((unsigned long)pagedir_nosave,pagedir_order);
- }
+ if ((error = data_read()))
+ free_pages((unsigned long)pagedir_nosave, pagedir_order);
return error;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-09-10 9:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-09-10 8:57 swsusp: another simplifycation Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®