mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Fix real bugs uncovered by -Wno-uninitialized removal
@ 2004-09-11  6:54 Anton Blanchard
  2004-09-11  7:53 ` [PATCH] Fix spurious warnings " Anton Blanchard
  2004-09-11 23:55 ` [PATCH] Fix real bugs uncovered by -Wno-uninitialized removal 2 Anton Blanchard
  0 siblings, 2 replies; 3+ messages in thread
From: Anton Blanchard @ 2004-09-11  6:54 UTC (permalink / raw)
  To: akpm; +Cc: paulus, linux-kernel


The removal of -Wno-uninitialized on ppc64 revealed a number of real
bugs.

Signed-off-by: Anton Blanchard <anton@samba.org>

diff -puN drivers/char/hvcs.c~realbugs drivers/char/hvcs.c
--- foobar2/drivers/char/hvcs.c~realbugs	2004-09-11 15:32:35.532933850 +1000
+++ foobar2-anton/drivers/char/hvcs.c	2004-09-11 15:32:35.580930160 +1000
@@ -427,7 +427,7 @@ static int hvcs_io(struct hvcs_struct *h
 	struct tty_struct *tty;
 	char buf[HVCS_BUFF_LEN] __ALIGNED__;
 	unsigned long flags;
-	int got;
+	int got = 0;
 	int i;
 
 	spin_lock_irqsave(&hvcsd->lock, flags);
@@ -945,7 +945,7 @@ static int hvcs_enable_device(struct hvc
  */
 struct hvcs_struct *hvcs_get_by_index(int index)
 {
-	struct hvcs_struct *hvcsd;
+	struct hvcs_struct *hvcsd = NULL;
 	unsigned long flags;
 
 	spin_lock(&hvcs_structs_lock);
@@ -1433,7 +1433,7 @@ static int __init hvcs_module_init(void)
 			" as a tty driver failed.\n");
 		hvcs_free_index_list();
 		put_tty_driver(hvcs_tty_driver);
-		return rc;
+		return -EIO;
 	}
 
 	hvcs_pi_buff = kmalloc(PAGE_SIZE, GFP_KERNEL);
diff -puN drivers/net/ibmveth.c~realbugs drivers/net/ibmveth.c
--- foobar2/drivers/net/ibmveth.c~realbugs	2004-09-11 15:32:35.538933389 +1000
+++ foobar2-anton/drivers/net/ibmveth.c	2004-09-11 15:41:13.949998616 +1000
@@ -885,13 +885,16 @@ static int __devinit ibmveth_probe(struc
 
 	mac_addr_p = (unsigned char *) vio_get_attribute(dev, VETH_MAC_ADDR, 0);
 	if(!mac_addr_p) {
-		ibmveth_error_printk("Can't find VETH_MAC_ADDR attribute\n");
+		printk(KERN_ERR "(%s:%3.3d) ERROR: Can't find VETH_MAC_ADDR "
+				"attribute\n", __FILE__, __LINE__); 
 		return 0;
 	}
 	
 	mcastFilterSize_p= (unsigned int *) vio_get_attribute(dev, VETH_MCAST_FILTER_SIZE, 0);
 	if(!mcastFilterSize_p) {
-		ibmveth_error_printk("Can't find VETH_MCAST_FILTER_SIZE attribute\n");
+		printk(KERN_ERR "(%s:%3.3d) ERROR: Can't find "
+				"VETH_MCAST_FILTER_SIZE attribute\n",
+				__FILE__, __LINE__); 
 		return 0;
 	}
 	
diff -puN drivers/pci/hotplug/rpaphp_core.c~realbugs drivers/pci/hotplug/rpaphp_core.c
--- foobar2/drivers/pci/hotplug/rpaphp_core.c~realbugs	2004-09-11 15:32:35.545932850 +1000
+++ foobar2-anton/drivers/pci/hotplug/rpaphp_core.c	2004-09-11 15:32:35.575930545 +1000
@@ -449,7 +449,7 @@ static int rpaphp_disable_slot(struct pc
 
 static int disable_slot(struct hotplug_slot *hotplug_slot)
 {
-	int retval;
+	int retval = -EINVAL;
 	struct slot *slot = (struct slot *)hotplug_slot->private;
 
 	dbg("%s - Entry: slot[%s]\n", __FUNCTION__, slot->name);
diff -puN drivers/pci/hotplug/rpaphp_pci.c~realbugs drivers/pci/hotplug/rpaphp_pci.c
--- foobar2/drivers/pci/hotplug/rpaphp_pci.c~realbugs	2004-09-11 15:32:35.551932389 +1000
+++ foobar2-anton/drivers/pci/hotplug/rpaphp_pci.c	2004-09-11 15:32:35.582930007 +1000
@@ -186,7 +186,7 @@ static struct pci_dev *
 rpaphp_pci_config_slot(struct device_node *dn, struct pci_bus *bus)
 {
 	struct device_node *eads_first_child = dn->child;
-	struct pci_dev *dev;
+	struct pci_dev *dev = NULL;
 	int num;
 	
 	dbg("Enter %s: dn=%s bus=%s\n", __FUNCTION__, dn->full_name, bus->name);
diff -puN arch/ppc64/kernel/iSeries_pci_reset.c~realbugs arch/ppc64/kernel/iSeries_pci_reset.c
--- foobar2/arch/ppc64/kernel/iSeries_pci_reset.c~realbugs	2004-09-11 16:11:41.437058963 +1000
+++ foobar2-anton/arch/ppc64/kernel/iSeries_pci_reset.c	2004-09-11 16:11:45.839379196 +1000
@@ -65,7 +65,8 @@ int iSeries_Device_ToggleReset(struct pc
 		AssertDelay = (5 * HZ) / 10;
 	else
 		AssertDelay = (AssertTime * HZ) / 10;
-	if (WaitDelay == 0)
+
+	if (DelayTime == 0)
 		WaitDelay = (30 * HZ) / 10;
 	else
 		WaitDelay = (DelayTime * HZ) / 10;
_

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-09-11 23:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-09-11  6:54 [PATCH] Fix real bugs uncovered by -Wno-uninitialized removal Anton Blanchard
2004-09-11  7:53 ` [PATCH] Fix spurious warnings " Anton Blanchard
2004-09-11 23:55 ` [PATCH] Fix real bugs uncovered by -Wno-uninitialized removal 2 Anton Blanchard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome