From: Tonnerre <tonnerre@thundrix.ch>
To: Natalie.Protasevich@unisys.com
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [patch 1/2] Incorrect PCI interrupt assignment on ES7000 for platform GSI
Date: Tue, 14 Sep 2004 04:35:33 +0200 [thread overview]
Message-ID: <20040914023533.GB20950@thundrix.ch> (raw)
In-Reply-To: <200409140151.i8E1p03W023713@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]
Salut,
On Mon, Sep 13, 2004 at 07:50:59PM -0600, Natalie.Protasevich@unisys.com wrote:
> diff -puN arch/i386/kernel/acpi/boot.c~mypatch arch/i386/kernel/acpi/boot.c
> --- linux/arch/i386/kernel/acpi/boot.c~mypatch 2004-09-13 14:08:21.192015024 -0600
> +++ linux-root/arch/i386/kernel/acpi/boot.c 2004-09-13 14:10:51.457171248 -0600
> @@ -442,6 +442,7 @@ int acpi_gsi_to_irq(u32 gsi, unsigned in
> unsigned int acpi_register_gsi(u32 gsi, int edge_level, int active_high_low)
> {
> unsigned int irq;
> + unsigned int plat_gsi;
>
> #ifdef CONFIG_PCI
> /*
> @@ -463,10 +464,10 @@ unsigned int acpi_register_gsi(u32 gsi,
>
> #ifdef CONFIG_X86_IO_APIC
> if (acpi_irq_model == ACPI_IRQ_MODEL_IOAPIC) {
> - mp_register_gsi(gsi, edge_level, active_high_low);
> + plat_gsi = mp_register_gsi(gsi, edge_level, active_high_low);
> }
> #endif
> - acpi_gsi_to_irq(gsi, &irq);
> + acpi_gsi_to_irq(plat_gsi, &irq);
> return irq;
> }
> EXPORT_SYMBOL(acpi_register_gsi);
Looking at that, won't that cause problems if we don't have IOAPIC?
Then you end up using an undefined value as GSI.
Tonnerre
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-09-14 2:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-14 1:50 Natalie.Protasevich
2004-09-14 2:35 ` Tonnerre [this message]
2004-09-14 3:36 Protasevich, Natalie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040914023533.GB20950@thundrix.ch \
--to=tonnerre@thundrix.ch \
--cc=Natalie.Protasevich@unisys.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®