Re: input: Disable the AUX LoopBack command in i8042.c on Compaq ProLiant

Re: input: Disable the AUX LoopBack command in i8042.c on Compaq ProLiant

[Arjan van de Ven]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

On Wed, 2004-06-02 at 13:44, Linux Kernel Mailing List wrote:
> ChangeSet 1.1722.87.1, 2004/06/02 13:44:20+02:00, vojtech@suse.cz
> 
> 	input: Disable the AUX LoopBack command in i8042.c on Compaq ProLiant
> 	       8-way Xeon ProFusion systems, as it causes crashes and reboots
> 	       on these machines. DMI data is used for determining if the
> 	       workaround should be enabled.
> 	
> 	Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>
> 

is there any reason you do this in dmi_scan.c and not via the "new"
since some time method where the user gives the dmi code a table with
callbacks instead ????


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: input: Disable the AUX LoopBack command in i8042.c on Compaq ProLiant

[Vojtech Pavlik]

On Thu, Sep 16, 2004 at 05:52:57PM +0200, Arjan van de Ven wrote:

> On Wed, 2004-06-02 at 13:44, Linux Kernel Mailing List wrote:
> > ChangeSet 1.1722.87.1, 2004/06/02 13:44:20+02:00, vojtech@suse.cz
> > 
> > 	input: Disable the AUX LoopBack command in i8042.c on Compaq ProLiant
> > 	       8-way Xeon ProFusion systems, as it causes crashes and reboots
> > 	       on these machines. DMI data is used for determining if the
> > 	       workaround should be enabled.
> > 	
> > 	Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>
> > 
> 
> is there any reason you do this in dmi_scan.c and not via the "new"
> since some time method where the user gives the dmi code a table with
> callbacks instead ????

There is no such reason other than on 06/02 there wasn't the "new"
method yet, as far as I know. In the same set of patches:

ChangeSet@1.1757.59.2, 2004-06-29 11:59:04+02:00, vojtech@suse.cz
  input: Move Compaq ProLiant DMI handling (ServerWorks/OSB workaround)
         to i8042.c.
         
  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR