Re: [patch] v4l/dvb: cx88 driver update

Re: [patch] v4l/dvb: cx88 driver update

[Andrew Morton]

Gerd Knorr <kraxel@bytesex.org> wrote:
>
> 
> This is a major update of the cx88 driver.

drivers/media/video/cx88/cx88-dvb.c:215: `FE_UNREGISTER' undeclared (first use in this function)
drivers/media/video/cx88/cx88-dvb.c:215: (Each undeclared identifier is reported only once
drivers/media/video/cx88/cx88-dvb.c:215: for each function it appears in.)
drivers/media/video/cx88/cx88-dvb.c: In function `dvb_register':
drivers/media/video/cx88/cx88-dvb.c:232: `FE_REGISTER' undeclared (first use in this function)
drivers/media/video/cx88/cx88-dvb.c:294: `FE_UNREGISTER' undeclared (first use in this function)

I'll drop this one - please wholly resend it.

Re: [patch] v4l/dvb: cx88 driver update

[Michael Hunold]

Hi,

  On 17.09.2004 01:08, Andrew Morton wrote:
> Gerd Knorr <kraxel@bytesex.org> wrote:

>>This is a major update of the cx88 driver.

> drivers/media/video/cx88/cx88-dvb.c:215: `FE_UNREGISTER' undeclared (first use in this function)
> drivers/media/video/cx88/cx88-dvb.c:215: (Each undeclared identifier is reported only once
> drivers/media/video/cx88/cx88-dvb.c:215: for each function it appears in.)
> drivers/media/video/cx88/cx88-dvb.c: In function `dvb_register':
> drivers/media/video/cx88/cx88-dvb.c:232: `FE_REGISTER' undeclared (first use in this function)
> drivers/media/video/cx88/cx88-dvb.c:294: `FE_UNREGISTER' undeclared (first use in this function)
> 
> I'll drop this one - please wholly resend it.

Currently bttv/cx88 and DVB in general get more and more interwoven.

I have been waiting for Gerd to submit his latest bttv patches, so I can 
send off my DVB patches.

Gerd's latest patch depends on my not-yet-submitted patches, so just 
simply drop this one. Gerd and I are going to coordinate this and 
resubmit it again. Ok, Gerd?

CU
Michael.

Re: [patch] v4l/dvb: cx88 driver update

[Gerd Knorr]

On Fri, Sep 17, 2004 at 08:37:35AM +0200, Michael Hunold wrote:
> Hi,
> 
>  On 17.09.2004 01:08, Andrew Morton wrote:
> >Gerd Knorr <kraxel@bytesex.org> wrote:
> 
> >>This is a major update of the cx88 driver.
> 
> >drivers/media/video/cx88/cx88-dvb.c:215: `FE_UNREGISTER' undeclared (first 
> >use in this function)

Whoops.  That wasn't intentional ...

> Gerd's latest patch depends on my not-yet-submitted patches, so just 
> simply drop this one. Gerd and I are going to coordinate this and 
> resubmit it again. Ok, Gerd?

I have a (temporary) #define for FE_(UN)REGISTER in there to relax the
dependencies between cx88 + dvb core a bit.  That way it is only a
runtime dependency and only for the dvb part of the cx88 driver.

Unfortunaly the #define catched only one of the two cases where it is
needed, and I didn't notice the second one as I'm working with a
dvb-patched kernel to actually test the stuff ...

Whats your planned timeframe for submitting the dvb updates?  I'd love
to see a working cx88 dvb driver in 2.6.9.

  Gerd

-- 
return -ENOSIG;