From: Matthew Wilcox <willy@debian.org>
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@zip.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] make make install install modules too
Date: Fri, 17 Sep 2004 18:00:51 +0100 [thread overview]
Message-ID: <20040917170051.GU642@parcelfarce.linux.theplanet.co.uk> (raw)
I keep forgetting to run 'make modules_install' after make install. Since
make now compiles modules too and there's no separate make modules step,
it seems to make sense that make install should also install modules.
Index: linux-2.6/arch/i386/Makefile
===================================================================
RCS file: /var/cvs/linux-2.6/arch/i386/Makefile,v
retrieving revision 1.11
diff -u -p -r1.11 Makefile
--- linux-2.6/arch/i386/Makefile 13 Sep 2004 15:22:09 -0000 1.11
+++ linux-2.6/arch/i386/Makefile 17 Sep 2004 16:57:03 -0000
@@ -117,7 +117,7 @@ AFLAGS += $(mflags-y)
boot := arch/i386/boot
.PHONY: zImage bzImage compressed zlilo bzlilo \
- zdisk bzdisk fdimage fdimage144 fdimage288 install
+ zdisk bzdisk fdimage fdimage144 fdimage288 install kernel_install
all: bzImage
@@ -136,8 +136,10 @@ zlilo bzlilo: vmlinux
zdisk bzdisk: vmlinux
$(Q)$(MAKE) $(build)=$(boot) BOOTIMAGE=$(KBUILD_IMAGE) zdisk
-install fdimage fdimage144 fdimage288: vmlinux
+kernel_install fdimage fdimage144 fdimage288: vmlinux
$(Q)$(MAKE) $(build)=$(boot) BOOTIMAGE=$(KBUILD_IMAGE) $@
+
+install: kernel_install modules_install
prepare: include/asm-$(ARCH)/asm_offsets.h
CLEAN_FILES += include/asm-$(ARCH)/asm_offsets.h
Index: linux-2.6/arch/i386/boot/Makefile
===================================================================
RCS file: /var/cvs/linux-2.6/arch/i386/boot/Makefile,v
retrieving revision 1.5
diff -u -p -r1.5 Makefile
--- linux-2.6/arch/i386/boot/Makefile 13 Sep 2004 15:22:09 -0000 1.5
+++ linux-2.6/arch/i386/boot/Makefile 17 Sep 2004 16:57:03 -0000
@@ -100,5 +100,5 @@ zlilo: $(BOOTIMAGE)
cp System.map $(INSTALL_PATH)/
if [ -x /sbin/lilo ]; then /sbin/lilo; else /etc/lilo/install; fi
-install: $(BOOTIMAGE)
+kernel_install: $(BOOTIMAGE)
sh $(srctree)/$(src)/install.sh $(KERNELRELEASE) $< System.map "$(INSTALL_PATH)"
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
next reply other threads:[~2004-09-17 17:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-17 17:00 Matthew Wilcox [this message]
2004-09-17 17:38 ` Gene Heskett
2004-09-26 1:33 ` Matthew Wilcox
2004-09-26 2:13 ` Gene Heskett
2004-09-27 7:22 ` Sam Ravnborg
2004-09-27 11:37 ` Matthew Wilcox
2004-09-27 12:27 ` Jesper Juhl
2004-09-27 16:34 ` Cal Peake
2004-09-27 18:10 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040917170051.GU642@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®