mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Gene Heskett <gene.heskett@verizon.net>
Cc: linux-kernel@vger.kernel.org, Matthew Wilcox <willy@debian.org>,
	Linus Torvalds <torvalds@osdl.org>,
	Andrew Morton <akpm@zip.com.au>
Subject: Re: [PATCH] make make install install modules too
Date: Sun, 26 Sep 2004 02:33:00 +0100	[thread overview]
Message-ID: <20040926013300.GL16153@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <200409171338.51924.gene.heskett@verizon.net>

On Fri, Sep 17, 2004 at 01:38:51PM -0400, Gene Heskett wrote:
> This is not a good patch IMO.  Many of us do things with scripts to 
> drive the compile process, either in the name of repeatability or 
> consistency.   These scripts may step out of the src tree and go make 
> something else (lm_sensors comes to mind when it wasn't part of the 
> kernel) whose output goes into the /lib/modules/version/ directory so 
> that by the time the make modules_install runs, everything is already 
> in place for the automatic depmod the modules_install does.  We 
> *could* work around it by re-adding the depmod lines to our scripts, 
> but it seems that might be called a kludge too.

Documentation/kbuild/modules.txt answers how to do this "right".  In any
case, there's nothing to stop you changing your scripts from
"make install && do_my_special_thing && make modules_install"
to
"make kernel_install && do_my_special_thing && make modules_install"

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

  reply	other threads:[~2004-09-26  1:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-17 17:00 Matthew Wilcox
2004-09-17 17:38 ` Gene Heskett
2004-09-26  1:33   ` Matthew Wilcox [this message]
2004-09-26  2:13     ` Gene Heskett
2004-09-27  7:22 ` Sam Ravnborg
2004-09-27 11:37   ` Matthew Wilcox
2004-09-27 12:27     ` Jesper Juhl
2004-09-27 16:34       ` Cal Peake
2004-09-27 18:10     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040926013300.GL16153@parcelfarce.linux.theplanet.co.uk \
    --to=matthew@wil.cx \
    --cc=akpm@zip.com.au \
    --cc=gene.heskett@verizon.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=willy@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®