Re: 2.6.9-rc2-mm1 swsusp bug report.

[Kevin Fenzi <kevin-linux-kernel@scrye.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>>>>> "Pavel" == Pavel Machek <pavel@ucw.cz> writes:

Pavel> Hi!
>> Was trying to swsusp my 2.6.9-rc2-mm1 laptop tonight. It churned
>> for a while, but didn't hibernate. Here are the messages.
>> 
>> ....................................................................................................
>> .........................swsusp: Need to copy 34850 pages Sep 23
>> 16:53:37 voldemort kernel: hibernate: page allocation
>> failure. order:8, mode:0x120 Sep 23 16:53:37 voldemort kernel:
Pavel> Out of memory... Try again with less loaded system. 

The system was no more loaded than usual. I have 1GB memory and 4GB of
swap defined. I almost never touch swap. It might have been 100mb into
the 4Gb of swap when this happened. 

What would cause it to be out of memory? 
swsup needs to be reliable... rebooting when you are using your memory
kinda defeats the purpose of swsusp. 

Felipe W Damasio <felipewd@terra.com.br> sent me a patch, but I
haven't had a chance to try it yet:

- --- linux-2.6.9-rc2-mm2/kernel/power/swsusp.c.orig	2004-09-23 23:46:49.292975768 -0300
+++ linux-2.6.9-rc2-mm2/kernel/power/swsusp.c	2004-09-24 00:07:01.933626368 -0300
@@ -657,6 +657,9 @@
 	int diff = 0;
 	int order = 0;
 
+	order = get_bitmask_order(SUSPEND_PD_PAGES(nr_copy_pages));
+	nr_copy_pages += 1 << order;
+
 	do {
 		diff = get_bitmask_order(SUSPEND_PD_PAGES(nr_copy_pages)) - order;
 		if (diff) {


kevin
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFBVI0m3imCezTjY0ERAgI1AJ0VatDEm27SAh2dvS65XwNNpReSEACeNBkn
uRXNP9tQcUlEZ1BAKON1nSo=
=3rnm
-----END PGP SIGNATURE-----