* 2.6.9-rc2-mm2 pcmcia oops
@ 2004-09-26 22:16 Lukas Hejtmanek
2004-09-27 1:43 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Lukas Hejtmanek @ 2004-09-26 22:16 UTC (permalink / raw)
To: linux-kernel
Unable to handle kernel paging request at virtual address 0000ffff
printing eip:
c0402097
*pde = 00000000
Oops: 0002 [#1]
PREEMPT
Modules linked in: yenta_socket pcmcia_core i830 ehci_hcd uhci_hcd rtc
CPU: 0
EIP: 0060:[<c0402097>] Tainted: P VLI
EFLAGS: 00010246 (2.6.9-rc2-mm2)
EIP is at quirk_usb_early_handoff+0x0/0x3e
eax: 0000ffff ebx: c035d954 ecx: c6866000 edx: 00020000
esi: c6866000 edi: c035da4c ebp: ceede380 esp: c7f4bed8
ds: 007b es: 007b ss: 0068
Process pccardd (pid: 3386, threadinfo=c7f4a000 task=c5ea2d70)
Stack: c01d2076 c6866000 c6866000 ceede380 00000000 c01d20ba c6866000 c035d81c
c035da4c c01d01ce 00000000 c6866000 00000000 00000000 c01d0214 ceede380
00000000 c686642c ceede380 ceede394 c7f4a000 cfbdd0de ceede380 00000000
Call Trace:
[<c01d2076>] pci_do_fixups+0x49/0x4b
[<c01d20ba>] pci_fixup_device+0x42/0x50
[<c01d01ce>] pci_scan_single_device+0x37/0x5e
[<c01d0214>] pci_scan_slot+0x1f/0x60
[<cfbdd0de>] cb_alloc+0x27/0xe5 [pcmcia_core]
[<cfbda264>] socket_insert+0xb4/0x151 [pcmcia_core]
[<cfbda54d>] socket_detect_change+0x58/0x82 [pcmcia_core]
[<cfbda740>] pccardd+0x1c9/0x245 [pcmcia_core]
[<c0117179>] default_wake_function+0x0/0x12
[<c0104ff6>] ret_from_fork+0x6/0x14
[<c0117179>] default_wake_function+0x0/0x12
[<cfbda577>] pccardd+0x0/0x245 [pcmcia_core]
[<c01032a9>] kernel_thread_helper+0x5/0xb
Code: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 <00> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
--
Lukáš Hejtmánek
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: 2.6.9-rc2-mm2 pcmcia oops
2004-09-26 22:16 2.6.9-rc2-mm2 pcmcia oops Lukas Hejtmanek
@ 2004-09-27 1:43 ` Andrew Morton
2004-09-27 6:00 ` Russell King
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2004-09-27 1:43 UTC (permalink / raw)
To: Lukas Hejtmanek; +Cc: linux-kernel, Greg KH
Lukas Hejtmanek <xhejtman@fi.muni.cz> wrote:
>
> Unable to handle kernel paging request at virtual address 0000ffff
> printing eip:
> c0402097
> *pde = 00000000
> Oops: 0002 [#1]
> PREEMPT
> Modules linked in: yenta_socket pcmcia_core i830 ehci_hcd uhci_hcd rtc
> CPU: 0
> EIP: 0060:[<c0402097>] Tainted: P VLI
> EFLAGS: 00010246 (2.6.9-rc2-mm2)
> EIP is at quirk_usb_early_handoff+0x0/0x3e
> eax: 0000ffff ebx: c035d954 ecx: c6866000 edx: 00020000
> esi: c6866000 edi: c035da4c ebp: ceede380 esp: c7f4bed8
> ds: 007b es: 007b ss: 0068
> Process pccardd (pid: 3386, threadinfo=c7f4a000 task=c5ea2d70)
> Stack: c01d2076 c6866000 c6866000 ceede380 00000000 c01d20ba c6866000 c035d81c
> c035da4c c01d01ce 00000000 c6866000 00000000 00000000 c01d0214 ceede380
> 00000000 c686642c ceede380 ceede394 c7f4a000 cfbdd0de ceede380 00000000
> Call Trace:
> [<c01d2076>] pci_do_fixups+0x49/0x4b
Well quirk_usb_early_handoff() should be __devinit, not __init.
There are a few other things in there which look hotpluggy, and are marked
__init. The whole thing needs a review.
diff -puN drivers/pci/quirks.c~pci-quirk-section-fixes drivers/pci/quirks.c
--- 25/drivers/pci/quirks.c~pci-quirk-section-fixes 2004-09-26 18:41:35.933120712 -0700
+++ 25-akpm/drivers/pci/quirks.c 2004-09-26 18:42:05.859571200 -0700
@@ -869,7 +869,7 @@ static int __init usb_handoff_early(char
}
__setup("usb-handoff", usb_handoff_early);
-static void __init quirk_usb_handoff_uhci(struct pci_dev *pdev)
+static void __devinit quirk_usb_handoff_uhci(struct pci_dev *pdev)
{
unsigned long base = 0;
int wait_time, delta;
@@ -922,7 +922,7 @@ static void __init quirk_usb_handoff_uhc
}
-static void __init quirk_usb_handoff_ohci(struct pci_dev *pdev)
+static void __devinit quirk_usb_handoff_ohci(struct pci_dev *pdev)
{
void __iomem *base;
int wait_time;
@@ -952,7 +952,7 @@ static void __init quirk_usb_handoff_ohc
iounmap(base);
}
-static void __init quirk_usb_disable_ehci(struct pci_dev *pdev)
+static void __devinit quirk_usb_disable_ehci(struct pci_dev *pdev)
{
int wait_time, delta;
void __iomem *base, *op_reg_base;
@@ -1042,7 +1042,7 @@ static void __init quirk_usb_disable_ehc
-static void __init quirk_usb_early_handoff(struct pci_dev *pdev)
+static void __devinit quirk_usb_early_handoff(struct pci_dev *pdev)
{
if (!usb_early_handoff)
return;
_
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: 2.6.9-rc2-mm2 pcmcia oops
2004-09-27 1:43 ` Andrew Morton
@ 2004-09-27 6:00 ` Russell King
2004-09-28 0:48 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Russell King @ 2004-09-27 6:00 UTC (permalink / raw)
To: Andrew Morton; +Cc: Lukas Hejtmanek, linux-kernel, Greg KH
On Sun, Sep 26, 2004 at 06:43:27PM -0700, Andrew Morton wrote:
> Well quirk_usb_early_handoff() should be __devinit, not __init.
I thought we got all those? I guess the recent PCI quirk cleanup
reintroduced these bugs.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: 2.6.9-rc2-mm2 pcmcia oops
2004-09-27 6:00 ` Russell King
@ 2004-09-28 0:48 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2004-09-28 0:48 UTC (permalink / raw)
To: Andrew Morton, Lukas Hejtmanek, linux-kernel
On Mon, Sep 27, 2004 at 07:00:23AM +0100, Russell King wrote:
> On Sun, Sep 26, 2004 at 06:43:27PM -0700, Andrew Morton wrote:
> > Well quirk_usb_early_handoff() should be __devinit, not __init.
>
> I thought we got all those? I guess the recent PCI quirk cleanup
> reintroduced these bugs.
No, these are new functions added in my trees. I'll go apply Andrew's
patch, it is correct.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-09-28 0:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-09-26 22:16 2.6.9-rc2-mm2 pcmcia oops Lukas Hejtmanek
2004-09-27 1:43 ` Andrew Morton
2004-09-27 6:00 ` Russell King
2004-09-28 0:48 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®