2.6.9-rc2-mm4 - Getting dev->irq equals 0

2.6.9-rc2-mm4 - Getting dev->irq equals 0

[Sy, Dely L]

Andrew,

I encountered a problem in running shpchp & pciehp drivers on
2.6.9-rc2-mm4 kernel.  With ACPI & MSI enabled in the kernel, I 
got dev->irq properly for the hot-plug controllers.  With ACPI 
enabled and MSI not-enabled in this kernel, I got dev->irq 
equal 0 for the controllers. With the same options set in 
2.6.8.1 & 2.6.9-rc2, things worked fine on the same system.

Do you know of any changes in the -mm4 that might have caused this
problem?

Thanks,
Dely

Re: 2.6.9-rc2-mm4 - Getting dev->irq equals 0

[Andrew Morton]

"Sy, Dely L" <dely.l.sy@intel.com> wrote:
>
> Andrew,
> 
> I encountered a problem in running shpchp & pciehp drivers on
> 2.6.9-rc2-mm4 kernel.  With ACPI & MSI enabled in the kernel, I 
> got dev->irq properly for the hot-plug controllers.  With ACPI 
> enabled and MSI not-enabled in this kernel, I got dev->irq 
> equal 0 for the controllers. With the same options set in 
> 2.6.8.1 & 2.6.9-rc2, things worked fine on the same system.
> 
> Do you know of any changes in the -mm4 that might have caused this
> problem?

Sorry, no, I cannot suggest where the problem lies.  Possibly
bk-acpi.patch, but that's quite small at present.

Re: 2.6.9-rc2-mm4 - Getting dev->irq equals 0

[Bjorn Helgaas]

> I encountered a problem in running shpchp & pciehp drivers on
> 2.6.9-rc2-mm4 kernel.  With ACPI & MSI enabled in the kernel, I 
> got dev->irq properly for the hot-plug controllers.  With ACPI 
> enabled and MSI not-enabled in this kernel, I got dev->irq 
> equal 0 for the controllers. With the same options set in 
> 2.6.8.1 & 2.6.9-rc2, things worked fine on the same system.

Does it make any difference if you boot with "pci=routeirq"?
I haven't looked at MSI recently, but it's possible that's
sensitive to have all the IRQs programmed at boot-time.

If that does make a difference, please send me the output
of lspci and a dmesg.

RE: 2.6.9-rc2-mm4 - Getting dev->irq equals 0

[Sy, Dely L]

On Friday, October 01, 2004 3:41 PM, Bjorn Helgaas wrote:
> > I encountered a problem in running shpchp & pciehp drivers on
> > 2.6.9-rc2-mm4 kernel.  With ACPI & MSI enabled in the kernel, I 
> > got dev->irq properly for the hot-plug controllers.  With ACPI 
> > enabled and MSI not-enabled in this kernel, I got dev->irq 
> > equal 0 for the controllers. With the same options set in 
> > 2.6.8.1 & 2.6.9-rc2, things worked fine on the same system.

> Does it make any difference if you boot with "pci=routeirq"?
> I haven't looked at MSI recently, but it's possible that's
> sensitive to have all the IRQs programmed at boot-time.

Basically, the problem found was when I tried to use INTx mode 
for hot-plug controllers in ACPI enabled kernel.  I don't think 
this is related to MSI; the way I stated in the original email 
was not clear.  

I tried to boot with "pci=routeirq" and I got proper dev->irq for 
the hot-plug controllers. This tells me that my hot-plug drivers 
need to call pci_enable_device(), correct?
  
> If that does make a difference, please send me the output
> of lspci and a dmesg.

I will send them to you.

Thanks,
Dely