From: Pavel Machek <pavel@ucw.cz>
To: kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@zip.com.au>,
Rusty trivial patch monkey Russell <trivial@rustcorp.com.au>
Subject: swsusp: add comments at critical places
Date: Mon, 4 Oct 2004 14:27:34 +0200 [thread overview]
Message-ID: <20041004122734.GA2648@elf.ucw.cz> (raw)
Hi!
apm.c needs save_processor_state and friends. Add a comment to keep
people from removing it. Describe a way to make swsusp work on non-PSE
machines. Document purpose of acpi_restore_state.
Pavel
Index: linux/arch/i386/power/cpu.c
===================================================================
--- linux.orig/arch/i386/power/cpu.c 2004-10-01 12:24:26.000000000 +0200
+++ linux/arch/i386/power/cpu.c 2004-10-01 00:47:37.000000000 +0200
@@ -148,6 +148,6 @@
__restore_processor_state(&saved_context);
}
-
+/* Needed by apm.c */
EXPORT_SYMBOL(save_processor_state);
EXPORT_SYMBOL(restore_processor_state);
Index: linux/include/asm-i386/suspend.h
===================================================================
--- linux.orig/include/asm-i386/suspend.h 2004-10-01 12:24:26.000000000 +0200
+++ linux/include/asm-i386/suspend.h 2004-08-19 12:18:51.000000000 +0200
@@ -9,6 +9,9 @@
static inline int
arch_prepare_suspend(void)
{
+ /* If you want to make non-PSE machine work, turn off paging
+ in do_magic. swsusp_pg_dir should have identity mapping, so
+ it could work... */
if (!cpu_has_pse)
return -EPERM;
return 0;
Index: linux/arch/i386/kernel/acpi/sleep.c
===================================================================
--- linux.orig/arch/i386/kernel/acpi/sleep.c 2004-10-01 12:24:26.000000000 +0200
+++ linux/arch/i386/kernel/acpi/sleep.c 2004-10-01 00:47:36.000000000 +0200
@@ -56,11 +56,11 @@
}
/*
- * acpi_restore_state
+ * acpi_restore_state - undo effects of acpi_save_state_mem
*/
void acpi_restore_state_mem (void)
{
- zap_low_mappings();
+ zap_low_mappings();
}
/**
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
reply other threads:[~2004-10-04 13:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041004122734.GA2648@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome