mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* swsusp: add comments at critical places
@ 2004-10-04 12:27 Pavel Machek
  0 siblings, 0 replies; only message in thread
From: Pavel Machek @ 2004-10-04 12:27 UTC (permalink / raw)
  To: kernel list, Andrew Morton, Rusty trivial patch monkey Russell

Hi!

apm.c needs save_processor_state and friends. Add a comment to keep
people from removing it. Describe a way to make swsusp work on non-PSE
machines. Document purpose of acpi_restore_state.
								Pavel

Index: linux/arch/i386/power/cpu.c
===================================================================
--- linux.orig/arch/i386/power/cpu.c	2004-10-01 12:24:26.000000000 +0200
+++ linux/arch/i386/power/cpu.c	2004-10-01 00:47:37.000000000 +0200
@@ -148,6 +148,6 @@
 	__restore_processor_state(&saved_context);
 }
 
-
+/* Needed by apm.c */
 EXPORT_SYMBOL(save_processor_state);
 EXPORT_SYMBOL(restore_processor_state);
Index: linux/include/asm-i386/suspend.h
===================================================================
--- linux.orig/include/asm-i386/suspend.h	2004-10-01 12:24:26.000000000 +0200
+++ linux/include/asm-i386/suspend.h	2004-08-19 12:18:51.000000000 +0200
@@ -9,6 +9,9 @@
 static inline int
 arch_prepare_suspend(void)
 {
+	/* If you want to make non-PSE machine work, turn off paging
+           in do_magic. swsusp_pg_dir should have identity mapping, so
+           it could work...  */
 	if (!cpu_has_pse)
 		return -EPERM;
 	return 0;
Index: linux/arch/i386/kernel/acpi/sleep.c
===================================================================
--- linux.orig/arch/i386/kernel/acpi/sleep.c	2004-10-01 12:24:26.000000000 +0200
+++ linux/arch/i386/kernel/acpi/sleep.c	2004-10-01 00:47:36.000000000 +0200
@@ -56,11 +56,11 @@
 }
 
 /*
- * acpi_restore_state
+ * acpi_restore_state - undo effects of acpi_save_state_mem
  */
 void acpi_restore_state_mem (void)
 {
-	zap_low_mappings();
+	zap_low_mappings();
 }
 
 /**


-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-10-04 13:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-04 12:27 swsusp: add comments at critical places Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome