From: Chuck Ebbert <76306.1226@compuserve.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Russell King <rmk@arm.linux.org.uk>
Subject: Re: [Patch] new serial flow control
Date: Tue, 5 Oct 2004 12:46:34 -0400 [thread overview]
Message-ID: <200410051249_MC3-1-8B8B-5504@compuserve.com> (raw)
Samual Thibault wrote:
>+ } else if (info->flags & ASYNC_TVB_FLOW) {
>+ if (status & UART_MSR_CTS) {
>+ if (!(info->MCR & UART_MCR_RTS)) {
>+ /* start of TVB frame, raise RTS to greet data */
>+ info->MCR |= UART_MCR_RTS;
>+ serial_out(info, UART_MCR, info->MCR);
>+#if (defined(SERIAL_DEBUG_INTR) || defined(SERIAL_DEBUG_FLOW))
>+ printk("TVB frame start...");
>+#endif
>+ }
>+ } else {
>+ if (info->MCR & UART_MCR_RTS) {
>+ /* CTS went down, lower RTS as well */
>+ info->MCR &= ~UART_MCR_RTS;
>+ serial_out(info, UART_MCR, info->MCR);
>+#if (defined(SERIAL_DEBUG_INTR) || defined(SERIAL_DEBUG_FLOW))
>+ printk("TVB frame started...");
>+#endif
^^^^^^^
Shouldn't this be "ended"? ... or "end" since frame begin msg says "start"
i.e. is not past tense?
--Chuck Ebbert
next reply other threads:[~2004-10-05 16:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-05 16:46 Chuck Ebbert [this message]
2004-10-05 17:25 ` Samuel Thibault
2004-10-07 19:08 ` Alan Cox
2004-10-07 20:27 ` Russell King
2004-10-07 22:08 ` Samuel Thibault
2004-10-07 23:10 ` Russell King
2004-10-07 21:43 ` Samuel Thibault
2004-10-07 22:55 ` Samuel Thibault
2004-10-08 18:59 ` Samuel Thibault
-- strict thread matches above, loose matches on Subject: below --
2004-10-07 11:08 Nick Craig-Wood
2004-10-04 22:54 Samuel Thibault
2004-10-04 22:55 ` Samuel Thibault
2004-10-05 22:51 ` Alan Cox
2004-10-06 7:11 ` Sébastien Hinderer
2004-10-06 7:38 ` Samuel Thibault
2004-10-06 13:29 ` Alan Cox
2004-10-07 1:30 ` Stuart MacDonald
2004-10-07 1:47 ` Paul Fulghum
2004-10-07 7:26 ` Sébastien Hinderer
2004-10-07 13:00 ` Alan Cox
2004-10-07 14:28 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410051249_MC3-1-8B8B-5504@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome