Re: [Patch] new serial flow control

[Samuel Thibault <samuel.thibault@ens-lyon.org>]

Le mar 05 oct 2004 à 12:46:34 -0400, Chuck Ebbert a tapoté sur son clavier :
> Samual Thibault wrote:
> 
> >+      } else if (info->flags & ASYNC_TVB_FLOW) {
> >+              if (status & UART_MSR_CTS) {
> >+                      if (!(info->MCR & UART_MCR_RTS)) {
> >+                              /* start of TVB frame, raise RTS to greet data */
> >+                              info->MCR |= UART_MCR_RTS;
> >+                              serial_out(info, UART_MCR, info->MCR);
> >+#if (defined(SERIAL_DEBUG_INTR) || defined(SERIAL_DEBUG_FLOW))
> >+                              printk("TVB frame start...");
> >+#endif
> >+                      }
> >+              } else {
> >+                      if (info->MCR & UART_MCR_RTS) {
> >+                              /* CTS went down, lower RTS as well */
> >+                              info->MCR &= ~UART_MCR_RTS;
> >+                              serial_out(info, UART_MCR, info->MCR);
> >+#if (defined(SERIAL_DEBUG_INTR) || defined(SERIAL_DEBUG_FLOW))
> >+                              printk("TVB frame started...");
> >+#endif
>                                                   ^^^^^^^
> 
> Shouldn't this be "ended"? ... or "end" since frame begin msg says "start"
> i.e. is not past tense?

No: data actually pass _after_ CTS and RTS are lowered back: the flow control
only indicate the beginning of one frame.

Regards,
Samuel Thibault