From: Jens Axboe <axboe@suse.de>
To: Christoph Hellwig <hch@infradead.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Subject: Re: [PATCH] ide-dma blacklist behaviour broken
Date: Tue, 5 Oct 2004 17:46:28 +0200 [thread overview]
Message-ID: <20041005154628.GG19971@suse.de> (raw)
In-Reply-To: <20041005163730.A19554@infradead.org>
On Tue, Oct 05 2004, Christoph Hellwig wrote:
> On Tue, Oct 05, 2004 at 04:20:01PM +0200, Jens Axboe wrote:
> > Hi,
> >
> > The blacklist stuff is broken. When set_using_dma() calls into
> > ide_dma_check(), it returns ide_dma_off() for a blacklisted drive. This
> > of course succeeds, returning success to the caller of ide_dma_check().
> > Not so good... It then uncondtionally calls ide_dma_on(), which turns on
> > dma for the drive.
> >
> > This moves the check to ide_dma_on() so we also catch the buggy
> > ->ide_dma_check() defined by various chipset drivers.
>
> Is this a bug introduced in the 2.6.9ish IDE changes or has it been there
> for a longer time?
I didn't check, someone just reported today. But looking at eg 2.6.5, it
seems to have the same bug. So it's likely very old.
--
Jens Axboe
next prev parent reply other threads:[~2004-10-05 15:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-05 14:20 Jens Axboe
2004-10-05 15:37 ` Christoph Hellwig
2004-10-05 15:46 ` Jens Axboe [this message]
2004-10-05 22:46 ` Alan Cox
2004-10-06 5:45 ` Jens Axboe
2004-10-06 13:27 ` Alan Cox
2004-10-06 14:41 ` Jens Axboe
2004-10-06 13:58 ` Alan Cox
2004-10-06 15:01 ` Jens Axboe
2004-10-05 19:30 ` Juri Haberland
2004-10-10 0:42 ` Bartlomiej Zolnierkiewicz
2004-10-10 8:14 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041005154628.GG19971@suse.de \
--to=axboe@suse.de \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome