From: Jens Axboe <axboe@suse.de>
To: Bartlomiej Zolnierkiewicz <bzolnier@elka.pw.edu.pl>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ide-dma blacklist behaviour broken
Date: Sun, 10 Oct 2004 10:14:56 +0200 [thread overview]
Message-ID: <20041010081455.GB14636@suse.de> (raw)
In-Reply-To: <200410100242.39249.bzolnier@elka.pw.edu.pl>
On Sun, Oct 10 2004, Bartlomiej Zolnierkiewicz wrote:
> > --- drivers/ide/ide-dma.c~ 2004-10-05 16:11:49.631910586 +0200
> > +++ drivers/ide/ide-dma.c 2004-10-05 16:21:58.828330845 +0200
> > @@ -354,11 +355,13 @@
> > struct hd_driveid *id = drive->id;
> > ide_hwif_t *hwif = HWIF(drive);
> >
> > - if ((id->capability & 1) && hwif->autodma) {
> > - /* Consult the list of known "bad" drives */
> > - if (__ide_dma_bad_drive(drive))
> > - return __ide_dma_off(drive);
> > + /* Consult the list of known "bad" drives */
> > + if (__ide_dma_bad_drive(drive)) {
> > + __ide_dma_off(drive);
> > + return 1;
> > + }
> >
> > + if ((id->capability & 1) && hwif->autodma) {
> > /*
> > * Enable DMA on any drive that has
> > * UltraDMA (mode 0/1/2/3/4/5/6) enabled
>
> Is __ide_dma_bad_drive() check still needed?
> Doesn't __ide_dma_on() fix handle this now?
Yeah, we can solely rely on that if we so wish.
--
Jens Axboe
prev parent reply other threads:[~2004-10-10 8:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-05 14:20 Jens Axboe
2004-10-05 15:37 ` Christoph Hellwig
2004-10-05 15:46 ` Jens Axboe
2004-10-05 22:46 ` Alan Cox
2004-10-06 5:45 ` Jens Axboe
2004-10-06 13:27 ` Alan Cox
2004-10-06 14:41 ` Jens Axboe
2004-10-06 13:58 ` Alan Cox
2004-10-06 15:01 ` Jens Axboe
2004-10-05 19:30 ` Juri Haberland
2004-10-10 0:42 ` Bartlomiej Zolnierkiewicz
2004-10-10 8:14 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041010081455.GB14636@suse.de \
--to=axboe@suse.de \
--cc=bzolnier@elka.pw.edu.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome