From: Pavel Machek <pavel@suse.cz>
To: Nigel Cunningham <ncunningham@linuxmail.org>
Cc: Andrew Morton <akpm@zip.com.au>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: __init poisoning for i386, too
Date: Thu, 7 Oct 2004 10:02:37 +0200 [thread overview]
Message-ID: <20041007080237.GC15057@elf.ucw.cz> (raw)
In-Reply-To: <1097106995.9693.54.camel@desktop.cunninghams>
Hi!
> On Thu, 2004-10-07 at 08:18, Pavel Machek wrote:
> > free_page(addr);
> > +#ifdef CONFIG_INIT_DEBUG
> > + memset((void *)(addr & ~(PAGE_SIZE-1)), 0xcc, PAGE_SIZE);
> > +#endif
>
> Shouldn't the memset be before the free_page? (Changing freed pages?)
Ouch, you are right. Interrupt could come and grab them. Yes, we need
first memset, then free_page().
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next prev parent reply other threads:[~2004-10-07 8:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-06 22:18 Pavel Machek
2004-10-06 22:29 ` Andrew Morton
2004-10-07 8:22 ` Geert Uytterhoeven
2004-10-06 23:56 ` Nigel Cunningham
2004-10-07 8:02 ` Pavel Machek [this message]
2004-10-07 6:16 ` William Lee Irwin III
2004-10-07 21:05 ` H. Peter Anvin
2004-10-08 11:08 ` William Lee Irwin III
2004-10-08 11:23 ` Ryan Cumming
[not found] <20041006221854.GA1622@elf.ucw.cz.suse.lists.linux.kernel>
[not found] ` <20041007061610.GU9106@holomorphy.com.suse.lists.linux.kernel>
2004-10-07 11:28 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041007080237.GC15057@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=ncunningham@linuxmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome