From: Ryan Cumming <ryan@spitfire.gotdns.org>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: __init poisoning for i386, too
Date: Fri, 8 Oct 2004 04:23:53 -0700 [thread overview]
Message-ID: <200410080423.57685.ryan@spitfire.gotdns.org> (raw)
In-Reply-To: <20041008110845.GC9106@holomorphy.com>
[-- Attachment #1.1: Type: text/plain, Size: 404 bytes --]
On Friday 08 October 2004 04:08, you wrote:
> On Thu, Oct 07, 2004 at 09:05:45PM +0000, H. Peter Anvin wrote:
> > What's wrong with using 0xCC (breakpoint instruction)?
> > If you want an illegal instruction, 0xFF 0xFF is an illegal
> > instruction, so filling memory with 0xFF will do what you want.
>
> That sounds better than what I suggested.
>
Here's the trivial patch against 2.4.9-rc3-mm3
-Ryan
[-- Attachment #1.2: trivial-initmem-tweak.diff --]
[-- Type: text/x-diff, Size: 502 bytes --]
--- linux-2.6.9-rc3-mm3/arch/i386/mm/init.c 2004-10-08 04:19:46.645395667 -0700
+++ linux-2.6.9-rc3-mm3-new/arch/i386/mm/init.c 2004-10-08 04:21:51.933318774 -0700
@@ -723,7 +723,7 @@
for (; addr < (unsigned long)(&__init_end); addr += PAGE_SIZE) {
ClearPageReserved(virt_to_page(addr));
set_page_count(virt_to_page(addr), 1);
- memset((void *)(addr & ~(PAGE_SIZE-1)), 0xcc, PAGE_SIZE);
+ memset((void *)(addr & ~(PAGE_SIZE-1)), 0xff, PAGE_SIZE);
free_page(addr);
totalram_pages++;
}
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-10-08 11:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-06 22:18 Pavel Machek
2004-10-06 22:29 ` Andrew Morton
2004-10-07 8:22 ` Geert Uytterhoeven
2004-10-06 23:56 ` Nigel Cunningham
2004-10-07 8:02 ` Pavel Machek
2004-10-07 6:16 ` William Lee Irwin III
2004-10-07 21:05 ` H. Peter Anvin
2004-10-08 11:08 ` William Lee Irwin III
2004-10-08 11:23 ` Ryan Cumming [this message]
[not found] <20041006221854.GA1622@elf.ucw.cz.suse.lists.linux.kernel>
[not found] ` <20041007061610.GU9106@holomorphy.com.suse.lists.linux.kernel>
2004-10-07 11:28 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410080423.57685.ryan@spitfire.gotdns.org \
--to=ryan@spitfire.gotdns.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome