From: Pavel Machek <pavel@suse.cz>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Patrick Mochel <mochel@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: swsusp resume doesn't sysdev_resume
Date: Thu, 14 Oct 2004 15:38:03 +0200 [thread overview]
Message-ID: <20041014133803.GA4144@elf.ucw.cz> (raw)
In-Reply-To: <200410111659.16373.bjorn.helgaas@hp.com>
Hi!
Sorry for long delay.
> Swsusp often fails on -mm kernels because sysdev_resume doesn't
> get called in the resume path. So things like ACPI IRQ links
> used by modular drivers don't get restored.
>
> We can work around this by using "pci=routeirq", so all the IRQ
> setup gets done at boot-time, but that's an ugly hack, and I
> expect that we'll trip over other sysdevs that need to be resumed
> anyway.
>
> I don't understand swsusp well enough to fix this. It's not enough
> to just call device_power_up() before device_resume(), because it
> relies on sysdev_suspend() having been called before the suspend
> image was created.
Can you try adding sysdev_suspend() and sysdev_resume() and see what
breaks? Its probably right thing to do...
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
prev parent reply other threads:[~2004-10-14 13:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-11 22:59 Bjorn Helgaas
2004-10-14 13:38 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041014133803.GA4144@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®