* swsusp resume doesn't sysdev_resume
@ 2004-10-11 22:59 Bjorn Helgaas
2004-10-14 13:38 ` Pavel Machek
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Helgaas @ 2004-10-11 22:59 UTC (permalink / raw)
To: Pavel Machek, Patrick Mochel; +Cc: linux-kernel
Swsusp often fails on -mm kernels because sysdev_resume doesn't
get called in the resume path. So things like ACPI IRQ links
used by modular drivers don't get restored.
We can work around this by using "pci=routeirq", so all the IRQ
setup gets done at boot-time, but that's an ugly hack, and I
expect that we'll trip over other sysdevs that need to be resumed
anyway.
I don't understand swsusp well enough to fix this. It's not enough
to just call device_power_up() before device_resume(), because it
relies on sysdev_suspend() having been called before the suspend
image was created.
Any hints?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: swsusp resume doesn't sysdev_resume
2004-10-11 22:59 swsusp resume doesn't sysdev_resume Bjorn Helgaas
@ 2004-10-14 13:38 ` Pavel Machek
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2004-10-14 13:38 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Patrick Mochel, linux-kernel
Hi!
Sorry for long delay.
> Swsusp often fails on -mm kernels because sysdev_resume doesn't
> get called in the resume path. So things like ACPI IRQ links
> used by modular drivers don't get restored.
>
> We can work around this by using "pci=routeirq", so all the IRQ
> setup gets done at boot-time, but that's an ugly hack, and I
> expect that we'll trip over other sysdevs that need to be resumed
> anyway.
>
> I don't understand swsusp well enough to fix this. It's not enough
> to just call device_power_up() before device_resume(), because it
> relies on sysdev_suspend() having been called before the suspend
> image was created.
Can you try adding sysdev_suspend() and sysdev_resume() and see what
breaks? Its probably right thing to do...
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-10-14 13:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-11 22:59 swsusp resume doesn't sysdev_resume Bjorn Helgaas
2004-10-14 13:38 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®