From: Matthew Wilcox <matthew@wil.cx>
To: Jeremy Higdon <jeremy@sgi.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
akpm@osdl.org, Jesse Barnes <jbarnes@engr.sgi.com>,
linux-kernel@vger.kernel.org, gnb@sgi.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] I/O space write barrier
Date: Sat, 16 Oct 2004 04:20:44 +0100 [thread overview]
Message-ID: <20041016032044.GB16153@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20041016003809.GA299051@sgi.com>
On Fri, Oct 15, 2004 at 05:38:09PM -0700, Jeremy Higdon wrote:
> - (void) RD_REG_WORD(®->mailbox4); /* PCI posted write flush */
> + /* Enforce mmio write ordering; see comment in qla1280_isp_cmd(). */
> + mmiowb();
I really don't think we want a comment by every mmiowb() explaining what
it does. We needed one by the write flush because it had two potential
meanings, and we didn't want people overoptimising it away. But mmiowb()
is clear and unambiguous.
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
next prev parent reply other threads:[~2004-10-16 3:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-27 18:03 Jesse Barnes
2004-09-29 10:36 ` Greg Banks
2004-09-29 20:35 ` David S. Miller
2004-09-29 20:43 ` Jesse Barnes
2004-09-29 20:50 ` David S. Miller
2004-09-30 2:23 ` Greg Banks
2004-09-29 22:55 ` Jesse Barnes
2004-09-30 7:15 ` Jeremy Higdon
2004-09-30 21:21 ` Guennadi Liakhovetski
2004-10-16 0:38 ` Jeremy Higdon
2004-10-16 3:20 ` Matthew Wilcox [this message]
2004-10-16 3:31 ` Jeremy Higdon
-- strict thread matches above, loose matches on Subject: below --
2004-10-21 23:13 Jesse Barnes
2004-10-22 1:01 ` Grant Grundler
2004-10-22 3:05 ` Jesse Barnes
2004-10-22 4:26 ` Greg Banks
2004-10-22 15:26 ` Grant Grundler
2004-10-05 22:38 Jesse Barnes
2004-10-04 20:39 Albert Cahalan
2004-10-04 21:20 ` Jesse Barnes
2004-10-05 0:32 ` Albert Cahalan
2004-10-05 1:22 ` Benjamin Herrenschmidt
2004-10-05 2:26 ` Jesse Barnes
2004-10-05 3:04 ` Benjamin Herrenschmidt
2004-10-05 15:33 ` Jesse Barnes
2004-10-05 22:41 ` Benjamin Herrenschmidt
2004-10-05 23:09 ` Jesse Barnes
2004-10-05 23:57 ` Roland Dreier
2004-10-06 1:45 ` Benjamin Herrenschmidt
2004-10-05 2:33 ` Jesse Barnes
2004-09-22 15:45 Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041016032044.GB16153@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=g.liakhovetski@gmx.de \
--cc=gnb@sgi.com \
--cc=jbarnes@engr.sgi.com \
--cc=jeremy@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®