mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-kernel@vger.kernel.org, ncunningham@linuxmail.org
Subject: Re: swsusp: 8-order allocation failure on demand (update)
Date: Sat, 16 Oct 2004 23:25:01 +0200	[thread overview]
Message-ID: <20041016212501.GG24434@elf.ucw.cz> (raw)
In-Reply-To: <200410162305.50794.rjw@sisk.pl>

Hi!

> > > > Unfortunately that's rather ugly. You'd ~32 bytes per 4K page, that's
> > > > almost 1% overhead, not nice. Better solution (but more work) is to
> > > > switch to link-lists or integrate swsusp2.
> > > 
> > > Well, I wonder if the page allocation failures are a swsusp problem,
> > > really.  
> > 
> > Yes, they are. Kernel memory allocation is not design to do 8-order
> > allocations properly. swsusp really should not use them.
> 
> Now that's clear, thanks.  Could you tell me, please, what I need to know to 
> understand the swsusp code and what I should start with?

On bootup, prealloc, say, order-9 alocation.

In alloc_pagedir(), do not allocate anything, but check that data fit
in preallocated area, and fail if not.

There's free_pages( pagedir_save, ...) somewhere, remove that so
pagedir is never freed and you can resume multiple times.
								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

      reply	other threads:[~2004-10-16 21:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2HO0C-4xh-29@gated-at.bofh.it>
     [not found] ` <2I5b2-88s-15@gated-at.bofh.it>
     [not found]   ` <2I5E5-6h-19@gated-at.bofh.it>
     [not found]     ` <2I7Zd-1TK-11@gated-at.bofh.it>
2004-09-25  1:05       ` 2.6.9-rc2-mm1 swsusp bug report Pascal Schmidt
2004-09-25 10:16         ` Pavel Machek
2004-10-10 18:17           ` Jan Rychter
2004-10-11 13:32             ` Pavel Machek
2004-10-11 14:53               ` Jan Rychter
2004-10-17 19:10                 ` Pavel Machek
2004-10-17 21:40                   ` Nigel Cunningham
2004-10-11  9:56           ` Stefan Seyfried
2004-10-11 14:59             ` Pavel Machek
2004-10-11 17:18               ` Stefan Seyfried
2004-10-11 19:58                 ` Rafael J. Wysocki
2004-10-12  8:55                   ` Pavel Machek
2004-10-13 17:29                     ` Rafael J. Wysocki
2004-10-14 21:47                       ` swsusp: 8-order allocation failure on demand (was: Re: 2.6.9-rc2-mm1 swsusp bug report.) Rafael J. Wysocki
2004-10-14 21:54                         ` swsusp: 8-order allocation failure on demand (update) Rafael J. Wysocki
2004-10-16 16:43                           ` Pavel Machek
2004-10-16 19:31                             ` Rafael J. Wysocki
2004-10-16 20:40                               ` Pavel Machek
2004-10-16 21:05                                 ` Rafael J. Wysocki
2004-10-16 21:25                                   ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041016212501.GG24434@elf.ucw.cz \
    --to=pavel@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncunningham@linuxmail.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®