* [PATCH 2.6 IrDA] Fix nsc-ircc dongle_id input
@ 2004-10-20 1:02 Jean Tourrilhes
0 siblings, 0 replies; only message in thread
From: Jean Tourrilhes @ 2004-10-20 1:02 UTC (permalink / raw)
To: David S. Miller, Linux kernel mailing list
ir269_nsc_dongle-2.diff :
~~~~~~~~~~~~~~~~~~~~~~~
<Original patch from Maik Broemme>
o [CRITICA] Don't Oops on invalid dongle-id in nsc-ircc driver
Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com>
diff -u -p linux/drivers/net/irda/nsc-ircc.d0.c linux/drivers/net/irda/nsc-ircc.c
--- linux/drivers/net/irda/nsc-ircc.d0.c Fri Oct 15 15:30:40 2004
+++ linux/drivers/net/irda/nsc-ircc.c Fri Oct 15 15:32:20 2004
@@ -351,8 +351,9 @@ static int __init nsc_ircc_open(int i, c
}
MESSAGE("IrDA: Registered device %s\n", dev->name);
- /* Check if user has supplied the dongle id or not */
- if (!dongle_id) {
+ /* Check if user has supplied a valid dongle id or not */
+ if ((dongle_id <= 0) ||
+ (dongle_id >= (sizeof(dongle_types) / sizeof(dongle_types[0]))) ) {
dongle_id = nsc_ircc_read_dongle_id(self->io.fir_base);
MESSAGE("%s, Found dongle: %s\n", driver_name,
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-10-20 1:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-20 1:02 [PATCH 2.6 IrDA] Fix nsc-ircc dongle_id input Jean Tourrilhes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®