From: Pavel Machek <pavel@ucw.cz>
To: kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@zip.com.au>,
Patrick Mochel <mochel@digitalimplant.org>
Subject: power/disk.c: small fixups
Date: Wed, 20 Oct 2004 20:16:17 +0200 [thread overview]
Message-ID: <20041020181617.GA29435@elf.ucw.cz> (raw)
Hi!
power_down may never ever fail, so it does not really need to return
anything. Kill obsolete code and fixup old comments. Please apply,
Pavel
--- foo/kernel/power/disk.c 19 Oct 2004 05:52:31 -0000 1.8
+++ foo/kernel/power/disk.c 20 Oct 2004 17:53:42 -0000
@@ -3,6 +3,7 @@
*
* Copyright (c) 2003 Patrick Mochel
* Copyright (c) 2003 Open Source Development Lab
+ * Copyright (c) 2004 Pavel Machek <pavel@suse.cz>
*
* This file is released under the GPLv2.
*
@@ -41,7 +43,7 @@
* there ain't no turning back.
*/
-static int power_down(u32 mode)
+static void power_down(u32 mode)
{
unsigned long flags;
int error = 0;
@@ -67,7 +69,6 @@
after resume. */
printk(KERN_CRIT "Please power me down manually\n");
while(1);
- return 0;
}
@@ -162,7 +163,7 @@
*
* If we're going through the firmware, then get it over with quickly.
*
- * If not, then call pmdis to do it's thing, then figure out how
+ * If not, then call swsusp to do it's thing, then figure out how
* to power down the system.
*/
@@ -184,18 +185,9 @@
if (in_suspend) {
pr_debug("PM: writing image.\n");
-
- /*
- * FIXME: Leftover from swsusp. Are they necessary?
- */
- mb();
- barrier();
-
error = swsusp_write();
- if (!error) {
- error = power_down(pm_disk_mode);
- pr_debug("PM: Power down failed.\n");
- }
+ if (!error)
+ power_down(pm_disk_mode);
} else
pr_debug("PM: Image restored successfully.\n");
swsusp_free();
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next reply other threads:[~2004-10-20 18:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 18:16 Pavel Machek [this message]
2004-10-20 19:37 ` Tim Cambrant
2004-10-20 19:44 ` Pavel Machek
2004-10-21 6:05 ` Con Kolivas
2004-10-21 6:24 ` Nick Piggin
2004-10-21 19:31 ` Bill Davidsen
2004-10-24 10:09 ` Matthias Urlichs
2004-10-24 14:17 ` Maciej W. Rozycki
2004-10-26 6:12 Clayton Weaver
2004-10-26 8:55 ` David Weinehall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041020181617.GA29435@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome