From: Pavel Machek <pavel@ucw.cz>
To: Tim Cambrant <cambrant@acc.umu.se>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: power/disk.c: small fixups
Date: Wed, 20 Oct 2004 21:44:34 +0200 [thread overview]
Message-ID: <20041020194434.GA10239@elf.ucw.cz> (raw)
In-Reply-To: <20041020193741.GA27096@shaka.acc.umu.se>
Hi!
> > power_down may never ever fail, so it does not really need to return
> > anything. Kill obsolete code and fixup old comments. Please apply,
> >
>
> ...
>
> > @@ -162,7 +163,7 @@
> > *
> > * If we're going through the firmware, then get it over with quickly.
> > *
> > - * If not, then call pmdis to do it's thing, then figure out how
> > + * If not, then call swsusp to do it's thing, then figure out how
> > * to power down the system.
> > */
>
> I hate to be picky, but changing "it's" to the more correct "its" would
> perhaps be nice to do when you're at it?
Fixed; I'll propagate it eventually, just will not regenerate current
patch for it, ok?
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next prev parent reply other threads:[~2004-10-21 6:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 18:16 Pavel Machek
2004-10-20 19:37 ` Tim Cambrant
2004-10-20 19:44 ` Pavel Machek [this message]
2004-10-21 6:05 ` Con Kolivas
2004-10-21 6:24 ` Nick Piggin
2004-10-21 19:31 ` Bill Davidsen
2004-10-24 10:09 ` Matthias Urlichs
2004-10-24 14:17 ` Maciej W. Rozycki
2004-10-26 6:12 Clayton Weaver
2004-10-26 8:55 ` David Weinehall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041020194434.GA10239@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=cambrant@acc.umu.se \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome