* Unwind information fix for the vsyscall DSO
@ 2004-10-24 23:01 Daniel Jacobowitz
2004-10-24 23:27 ` Linus Torvalds
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Jacobowitz @ 2004-10-24 23:01 UTC (permalink / raw)
To: Andrew Morton, Linus Torvalds; +Cc: linux-kernel, Roland McGrath
When working on GDB support I found a typo. I assume the comment is
correct. If you step to this particular instruction and backtrace, GDB gets
lost.
I haven't tested the fixed version yet, but I'm pretty confident in this
patch :-) Please apply.
--- arch/i386/kernel/vsyscall-sysenter.S.orig 2004-04-05 21:21:20.000000000 -0400
+++ arch/i386/kernel/vsyscall-sysenter.S 2004-10-24 18:50:54.000000000 -0400
@@ -84,7 +84,7 @@
.byte 0x04 /* DW_CFA_advance_loc4 */
.long .Lpop_ebp-.Lenter_kernel
.byte 0x0e /* DW_CFA_def_cfa_offset */
- .byte 0x12 /* RA at offset 12 now */
+ .byte 0x0c /* RA at offset 12 now */
.byte 0xc5 /* DW_CFA_restore %ebp */
.byte 0x04 /* DW_CFA_advance_loc4 */
.long .Lpop_edx-.Lpop_ebp
--
Daniel Jacobowitz
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Unwind information fix for the vsyscall DSO
2004-10-24 23:01 Unwind information fix for the vsyscall DSO Daniel Jacobowitz
@ 2004-10-24 23:27 ` Linus Torvalds
2004-10-25 2:26 ` Daniel Jacobowitz
0 siblings, 1 reply; 3+ messages in thread
From: Linus Torvalds @ 2004-10-24 23:27 UTC (permalink / raw)
To: Daniel Jacobowitz; +Cc: Andrew Morton, linux-kernel, Roland McGrath
On Sun, 24 Oct 2004, Daniel Jacobowitz wrote:
>
> When working on GDB support I found a typo. I assume the comment is
> correct. If you step to this particular instruction and backtrace, GDB gets
> lost.
>
> I haven't tested the fixed version yet, but I'm pretty confident in this
> patch :-) Please apply.
The patch looks obvious, but I'd still like to see a "yeah, I tested it
now, and yes, gdb DTRT after the fix.."
Linus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Unwind information fix for the vsyscall DSO
2004-10-24 23:27 ` Linus Torvalds
@ 2004-10-25 2:26 ` Daniel Jacobowitz
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Jacobowitz @ 2004-10-25 2:26 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Andrew Morton, linux-kernel, Roland McGrath
On Sun, Oct 24, 2004 at 04:27:13PM -0700, Linus Torvalds wrote:
>
>
> On Sun, 24 Oct 2004, Daniel Jacobowitz wrote:
> >
> > When working on GDB support I found a typo. I assume the comment is
> > correct. If you step to this particular instruction and backtrace, GDB gets
> > lost.
> >
> > I haven't tested the fixed version yet, but I'm pretty confident in this
> > patch :-) Please apply.
>
> The patch looks obvious, but I'd still like to see a "yeah, I tested it
> now, and yes, gdb DTRT after the fix.."
It looks good, but it triggered a related bug in GDB and 2.6.10-rc1
locked up while I was debugging that. I'll get back to you once I can
test it.
--
Daniel Jacobowitz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-10-25 2:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-24 23:01 Unwind information fix for the vsyscall DSO Daniel Jacobowitz
2004-10-24 23:27 ` Linus Torvalds
2004-10-25 2:26 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome