mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Colin Leroy <colin@colino.net>
To: linux-kernel@vger.kernel.org
Cc: linux-usb-devel@lists.sf.net
Subject: 2.6.10-rc1 OHCI usb error messages
Date: Tue, 26 Oct 2004 17:28:43 +0200	[thread overview]
Message-ID: <20041026172843.6ac07c1a.colin@colino.net> (raw)

Hi,

2.6.10-rc1 gives the following error messages on my iBook G4, which uses
the ohci-hcd driver:

usb usb2: usbfs: USBDEVFS_CONTROL failed cmd usbmodules rqt 128 rq 6 len 18 ret -113
usb usb2: usbfs: USBDEVFS_CONTROL failed cmd usbmodules rqt 128 rq 6 len 18 ret -113
usb usb2: usbfs: USBDEVFS_CONTROL failed cmd usbmodules rqt 128 rq 6 len 18 ret -113
usb usb3: usbfs: USBDEVFS_CONTROL failed cmd usbmodules rqt 128 rq 6 len 18 ret -113
usb usb3: usbfs: USBDEVFS_CONTROL failed cmd usbmodules rqt 128 rq 6 len 18 ret -113
usb usb3: usbfs: USBDEVFS_CONTROL failed cmd usbmodules rqt 128 rq 6 len 18 ret -113
usb usb3: string descriptor 0 read error: -113
usb usb3: string descriptor 0 read error: -113
usb usb3: string descriptor 0 read error: -113
usb usb2: string descriptor 0 read error: -113
usb usb2: string descriptor 0 read error: -113
...
usb usb2: string descriptor 0 read error: -113
usb usb2: string descriptor 0 read error: -113

It worked correctly under 2.6.9. Give the error number, I'd guess the culprit 
is this hunk:
--- a/drivers/usb/host/ohci-hub.c       2004-10-22 14:40:57 -07:00
+++ b/drivers/usb/host/ohci-hub.c       2004-10-22 14:40:57 -07:00
...
@@ -146,10 +120,11 @@
        ohci->next_statechange = jiffies + msecs_to_jiffies (5);
                                                                                
 succeed:
-       /* it's not USB_STATE_SUSPENDED unless access to this
+       /* it's not HCD_STATE_SUSPENDED unless access to this
         * hub from the non-usb side (PCI, SOC, etc) stopped
         */
        root->dev.power.power_state = 3;
+       usb_set_device_state (root, USB_STATE_SUSPENDED);
 done:
        spin_unlock_irq (&ohci->lock);
        return status;

(Note also that this may be due to the patch to swsusp to make it work on 
PPC, but I had this patch with 2.6.9 too.)

-- 
Colin

             reply	other threads:[~2004-10-26 15:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-26 15:28 Colin Leroy [this message]
2004-10-26 16:05 ` [linux-usb-devel] " David Brownell
2004-10-27  7:19   ` [PATCH] usb: don't spit out too much errors with suspended devices Colin Leroy
2004-10-27 23:13     ` David Brownell
2004-10-28  6:37       ` Colin Leroy
2004-10-27  9:07   ` [linux-usb-devel] 2.6.10-rc1 OHCI usb error messages Colin Leroy
2004-10-27 22:59     ` David Brownell
2004-10-28  9:07       ` Colin Leroy
2004-10-28 14:10         ` David Brownell
2004-10-28 14:46       ` Alan Stern
2004-10-28 16:51         ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041026172843.6ac07c1a.colin@colino.net \
    --to=colin@colino.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sf.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®