mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Colin Leroy <colin@colino.net>
To: David Brownell <david-b@pacbell.net>
Cc: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [PATCH] usb: don't spit out too much errors with suspended devices
Date: Wed, 27 Oct 2004 09:19:25 +0200	[thread overview]
Message-ID: <20041027091925.56d31d91.colin@colino.net> (raw)
In-Reply-To: <200410260905.14869.david-b@pacbell.net>

On 26 Oct 2004 at 09h10, David Brownell wrote:

Hi, 

> What's wrong there is emitting voluminous diagnostics for
> something that's not an error ... the root hub is suspended,
> and as with any suspended device, you can't talk to it.
> The descriptor read logic can skip retries in that case, and
> usbfs should refuse up front to talk to suspended devices.
> (Silently!)

Here's a patch that does it. Hope it's fine.

Signed-off-by: Colin Leroy <colin@colino.net>

--- a/drivers/usb/core/message.c	2004-10-27 09:09:34.332120419 +0200
+++ b/drivers/usb/core/message.c	2004-10-27 09:15:05.323320163 +0200
@@ -703,6 +705,8 @@
 	int err;
 	unsigned int u, idx;
 
+	if (dev->state == USB_STATE_SUSPENDED)
+		return -EHOSTUNREACH;
 	if (size <= 0 || !buf || !index)
 		return -EINVAL;
 	buf[0] = 0;
--- a/drivers/usb/core/devio.c	2004-10-27 09:08:45.401856241 +0200
+++ b/drivers/usb/core/devio.c	2004-10-27 09:16:09.079846340 +0200
@@ -541,6 +541,8 @@
 	unsigned char *tbuf;
 	int i, j, ret;
 
+	if (dev->state == USB_STATE_SUSPENDED)
+		return -EHOSTUNREACH;
 	if (copy_from_user(&ctrl, arg, sizeof(ctrl)))
 		return -EFAULT;
 	if ((ret = check_ctrlrecip(ps, ctrl.bRequestType, ctrl.wIndex)))

  reply	other threads:[~2004-10-27  7:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-26 15:28 2.6.10-rc1 OHCI usb error messages Colin Leroy
2004-10-26 16:05 ` [linux-usb-devel] " David Brownell
2004-10-27  7:19   ` Colin Leroy [this message]
2004-10-27 23:13     ` [PATCH] usb: don't spit out too much errors with suspended devices David Brownell
2004-10-28  6:37       ` Colin Leroy
2004-10-27  9:07   ` [linux-usb-devel] 2.6.10-rc1 OHCI usb error messages Colin Leroy
2004-10-27 22:59     ` David Brownell
2004-10-28  9:07       ` Colin Leroy
2004-10-28 14:10         ` David Brownell
2004-10-28 14:46       ` Alan Stern
2004-10-28 16:51         ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041027091925.56d31d91.colin@colino.net \
    --to=colin@colino.net \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome