From: Jens Axboe <axboe@suse.de>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: Linus Torvalds <torvalds@osdl.org>
Subject: [PATCH] cfq v2 switch bug
Date: Wed, 27 Oct 2004 07:54:56 +0200 [thread overview]
Message-ID: <20041027055456.GC15910@suse.de> (raw)
Hi,
Fix online switching issue with cfq v2. It does deferred clearing of
e->elevator_data, which screws up the current io scheduler. It does not
have to, so just remove it.
Signed-off-by: Jens Axboe <axboe@suse.de>
--- /opt/kernel/linux-2.6.9-mm1/drivers/block/cfq-iosched.c 2004-10-25 17:17:19.000000000 +0200
+++ linux-2.6.9-mm1/drivers/block/cfq-iosched.c 2004-10-26 15:07:51.146772400 +0200
@@ -1482,7 +1482,6 @@
static void cfq_put_cfqd(struct cfq_data *cfqd)
{
request_queue_t *q = cfqd->queue;
- elevator_t *e = q->elevator;
struct cfq_queue *cfqq;
if (!atomic_dec_and_test(&cfqd->ref))
@@ -1500,7 +1499,6 @@
blk_put_queue(q);
- e->elevator_data = NULL;
mempool_destroy(cfqd->crq_pool);
kfree(cfqd->crq_hash);
kfree(cfqd->cfq_hash);
--
Jens Axboe
reply other threads:[~2004-10-27 5:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041027055456.GC15910@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome