mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] cfq v2 switch bug
@ 2004-10-27  5:54 Jens Axboe
  0 siblings, 0 replies; only message in thread
From: Jens Axboe @ 2004-10-27  5:54 UTC (permalink / raw)
  To: Linux Kernel; +Cc: Linus Torvalds

Hi,

Fix online switching issue with cfq v2. It does deferred clearing of
e->elevator_data, which screws up the current io scheduler. It does not
have to, so just remove it.

Signed-off-by: Jens Axboe <axboe@suse.de>

--- /opt/kernel/linux-2.6.9-mm1/drivers/block/cfq-iosched.c	2004-10-25 17:17:19.000000000 +0200
+++ linux-2.6.9-mm1/drivers/block/cfq-iosched.c	2004-10-26 15:07:51.146772400 +0200
@@ -1482,7 +1482,6 @@
 static void cfq_put_cfqd(struct cfq_data *cfqd)
 {
 	request_queue_t *q = cfqd->queue;
-	elevator_t *e = q->elevator;
 	struct cfq_queue *cfqq;
 
 	if (!atomic_dec_and_test(&cfqd->ref))
@@ -1500,7 +1499,6 @@
 
 	blk_put_queue(q);
 
-	e->elevator_data = NULL;
 	mempool_destroy(cfqd->crq_pool);
 	kfree(cfqd->crq_hash);
 	kfree(cfqd->cfq_hash);

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-10-27  5:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-27  5:54 [PATCH] cfq v2 switch bug Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome