mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	ak@suse.de
Subject: Re: 2.6.10-rc4-mm1 hpet compile fix for AMD64
Date: Wed, 27 Oct 2004 19:27:39 -0700	[thread overview]
Message-ID: <20041027192739.A6088@unix-os.sc.intel.com> (raw)
In-Reply-To: <1098914436.20643.155.camel@dyn318077bld.beaverton.ibm.com>; from pbadari@us.ibm.com on Wed, Oct 27, 2004 at 03:00:37PM -0700


On Wed, Oct 27, 2004 at 03:00:37PM -0700, Badari Pulavarty wrote:
> Hi Andrew,
> 
> Here is the HPET compile fix for AMD64. Without this, you 
> get following link error. (without HPET)
> 
> arch/x86_64/kernel/built-in.o(.text+0x6426): In function `timer_resume':
> arch/x86_64/kernel/time.c:971: undefined reference to `is_hpet_enabled'
> 
> 

That would be a bug introduced by my hpet-reenabling-after-suspend-resume.patch
This should be a better fix.

Thanks,
Venki

Signed-off-by:: "Venkatesh Pallipadi" <venkatesh.pallipadi@intel.com>

--- linux-2.6.9//arch/x86_64/kernel/time.c.org	2004-10-05 15:23:44.903948384 -0700
+++ linux-2.6.9//arch/x86_64/kernel/time.c	2004-10-05 15:30:41.242655280 -0700
@@ -899,7 +899,7 @@ static int timer_resume(struct sys_devic
 	unsigned long flags;
 	unsigned long sec;
 
-	if (is_hpet_enabled())
+	if (vxtime.hpet_address)
 		hpet_reenable();
 
 	sec = get_cmos_time() + clock_cmos_diff;

      reply	other threads:[~2004-10-28  2:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-27 22:00 Badari Pulavarty
2004-10-28  2:27 ` Venkatesh Pallipadi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041027192739.A6088@unix-os.sc.intel.com \
    --to=venkatesh.pallipadi@intel.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbadari@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®