mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* 2.6.10-rc4-mm1 hpet compile fix for AMD64
@ 2004-10-27 22:00 Badari Pulavarty
  2004-10-28  2:27 ` Venkatesh Pallipadi
  0 siblings, 1 reply; 2+ messages in thread
From: Badari Pulavarty @ 2004-10-27 22:00 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

Hi Andrew,

Here is the HPET compile fix for AMD64. Without this, you 
get following link error. (without HPET)

arch/x86_64/kernel/built-in.o(.text+0x6426): In function `timer_resume':
arch/x86_64/kernel/time.c:971: undefined reference to `is_hpet_enabled'


Thanks,
Badari



[-- Attachment #2: hpet_compile_fix.patch --]
[-- Type: text/plain, Size: 430 bytes --]

--- linux.org/arch/x86_64/kernel/time.c	2004-10-27 15:33:22.369395312 -0700
+++ linux/arch/x86_64/kernel/time.c	2004-10-27 15:36:09.458993832 -0700
@@ -968,8 +968,10 @@ static int timer_resume(struct sys_devic
 	unsigned long flags;
 	unsigned long sec;
 
+#ifdef CONFIG_HPET_EMULATE_RTC
 	if (is_hpet_enabled())
 		hpet_reenable();
+#endif
 
 	sec = get_cmos_time() + clock_cmos_diff;
 	write_seqlock_irqsave(&xtime_lock,flags);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: 2.6.10-rc4-mm1 hpet compile fix for AMD64
  2004-10-27 22:00 2.6.10-rc4-mm1 hpet compile fix for AMD64 Badari Pulavarty
@ 2004-10-28  2:27 ` Venkatesh Pallipadi
  0 siblings, 0 replies; 2+ messages in thread
From: Venkatesh Pallipadi @ 2004-10-28  2:27 UTC (permalink / raw)
  To: Badari Pulavarty; +Cc: Andrew Morton, Linux Kernel Mailing List, ak


On Wed, Oct 27, 2004 at 03:00:37PM -0700, Badari Pulavarty wrote:
> Hi Andrew,
> 
> Here is the HPET compile fix for AMD64. Without this, you 
> get following link error. (without HPET)
> 
> arch/x86_64/kernel/built-in.o(.text+0x6426): In function `timer_resume':
> arch/x86_64/kernel/time.c:971: undefined reference to `is_hpet_enabled'
> 
> 

That would be a bug introduced by my hpet-reenabling-after-suspend-resume.patch
This should be a better fix.

Thanks,
Venki

Signed-off-by:: "Venkatesh Pallipadi" <venkatesh.pallipadi@intel.com>

--- linux-2.6.9//arch/x86_64/kernel/time.c.org	2004-10-05 15:23:44.903948384 -0700
+++ linux-2.6.9//arch/x86_64/kernel/time.c	2004-10-05 15:30:41.242655280 -0700
@@ -899,7 +899,7 @@ static int timer_resume(struct sys_devic
 	unsigned long flags;
 	unsigned long sec;
 
-	if (is_hpet_enabled())
+	if (vxtime.hpet_address)
 		hpet_reenable();
 
 	sec = get_cmos_time() + clock_cmos_diff;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-10-28  2:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-27 22:00 2.6.10-rc4-mm1 hpet compile fix for AMD64 Badari Pulavarty
2004-10-28  2:27 ` Venkatesh Pallipadi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®