From: Chris Wright <chrisw@osdl.org>
To: jamesclv@us.ibm.com, ak@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] clustered apic patch missing APIC_DFR_CLUSTER def
Date: Thu, 28 Oct 2004 11:27:15 -0700 [thread overview]
Message-ID: <20041028112715.D14339@build.pdx.osdl.net> (raw)
The cluster apic support does not compile. I added the APIC_DFR_CLUSTER
def to asm-x86_64/apicdef.h (stolen from i386 one). Also added
APIC_DFR_FLAT while there. This may only be papering over real fix.
Additionally, cluster_cpu_present_to_apicid() is defined but not used
anywhere. So remove it.
Signed-off-by: Chris Wright <chrisw@osdl.org>
===== include/asm-x86_64/apicdef.h 1.6 vs edited =====
--- 1.6/include/asm-x86_64/apicdef.h 2004-10-28 00:39:50 -07:00
+++ edited/include/asm-x86_64/apicdef.h 2004-10-28 11:15:19 -07:00
@@ -32,6 +32,8 @@
#define SET_APIC_LOGICAL_ID(x) (((x)<<24))
#define APIC_ALL_CPUS 0xFFu
#define APIC_DFR 0xE0
+#define APIC_DFR_CLUSTER 0x0FFFFFFFu
+#define APIC_DFR_FLAT 0xFFFFFFFFu
#define APIC_SPIV 0xF0
#define APIC_SPIV_FOCUS_DISABLED (1<<9)
#define APIC_SPIV_APIC_ENABLED (1<<8)
===== arch/x86_64/kernel/genapic_cluster.c 1.1 vs edited =====
--- 1.1/arch/x86_64/kernel/genapic_cluster.c 2004-10-28 00:39:50 -07:00
+++ edited/arch/x86_64/kernel/genapic_cluster.c 2004-10-28 11:18:10 -07:00
@@ -57,14 +57,6 @@
apic_write_around(APIC_LDR, val);
}
-static int cluster_cpu_present_to_apicid(int mps_cpu)
-{
- if ((unsigned)mps_cpu < NR_CPUS)
- return (int)bios_cpu_apicid[mps_cpu];
- else
- return BAD_APICID;
-}
-
/* Start with all IRQs pointing to boot CPU. IRQ balancing will shift them. */
static cpumask_t cluster_target_cpus(void)
next reply other threads:[~2004-10-28 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-28 18:27 Chris Wright [this message]
2004-10-28 23:35 ` James Cleverdon
2004-10-28 23:38 ` Andi Kleen
2004-10-28 23:51 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041028112715.D14339@build.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=ak@suse.de \
--cc=jamesclv@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®